Skip to content

Commit a3dbdca

Browse files
author
Emmanouil Konstantinidis
committed
Destroy the authWindow on callback
1 parent 5d1dc6b commit a3dbdca

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/js/components/login.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ var Login = React.createClass({
5050

5151
if (code || error) {
5252
// Close the browser if code found or error
53-
authWindow.close();
53+
authWindow.destroy();
5454
}
5555

5656
// If there is a code, proceed to get token from github
@@ -64,8 +64,8 @@ var Login = React.createClass({
6464

6565
// If "Done" button is pressed, hide "Loading"
6666
authWindow.on('close', function () {
67-
authWindow = null;
68-
}, false);
67+
authWindow.destroy();
68+
});
6969

7070
},
7171

0 commit comments

Comments
 (0)