remove obsolete network merge tests

Author: Mossaka

pkg/workflow/compiler_test.go

@@ -2119,204 +2119,6 @@ func TestGenerateJobName(t *testing.T) {
 	}
 }
 
-func TestNetworkPermissionsDefaultBehavior(t *testing.T) {
-	compiler := NewCompiler(false, "", "test")
-
-	tmpDir := testutil.TempDir(t, "test-*")
-
-	t.Run("no network field defaults to full access", func(t *testing.T) {
-		testContent := `---
-on: push
-engine: claude
-strict: false
----
-
-# Test Workflow
-
-This is a test workflow without network permissions.
-`
-		testFile := filepath.Join(tmpDir, "no-network-workflow.md")
-		if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
-			t.Fatal(err)
-		}
-
-		// Compile the workflow
-		err := compiler.CompileWorkflow(testFile)
-		if err != nil {
-			t.Fatalf("Unexpected compilation error: %v", err)
-		}
-
-		// Read the compiled output
-		lockFile := filepath.Join(tmpDir, "no-network-workflow.lock.yml")
-		lockContent, err := os.ReadFile(lockFile)
-		if err != nil {
-			t.Fatalf("Failed to read lock file: %v", err)
-		}
-
-		// Should contain network hook setup (defaults to allow-list)
-		if !strings.Contains(string(lockContent), "Generate Network Permissions Hook") {
-			t.Error("Should contain network hook setup when no network field specified (defaults to allow-list)")
-		}
-	})
-
-	t.Run("network: defaults should enforce allow-list restrictions", func(t *testing.T) {
-		testContent := `---
-on: push
-engine: claude
-strict: false
-network: defaults
----
-
-# Test Workflow
-
-This is a test workflow with explicit defaults network permissions.
-`
-		testFile := filepath.Join(tmpDir, "defaults-network-workflow.md")
-		if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
-			t.Fatal(err)
-		}
-
-		// Compile the workflow
-		err := compiler.CompileWorkflow(testFile)
-		if err != nil {
-			t.Fatalf("Unexpected compilation error: %v", err)
-		}
-
-		// Read the compiled output
-		lockFile := filepath.Join(tmpDir, "defaults-network-workflow.lock.yml")
-		lockContent, err := os.ReadFile(lockFile)
-		if err != nil {
-			t.Fatalf("Failed to read lock file: %v", err)
-		}
-
-		// Should contain network hook setup (defaults mode uses allow-list)
-		if !strings.Contains(string(lockContent), "Generate Network Permissions Hook") {
-			t.Error("Should contain network hook setup for network: defaults (uses allow-list)")
-		}
-	})
-
-	t.Run("network: {} should enforce deny-all", func(t *testing.T) {
-		testContent := `---
-on: push
-engine: claude
-strict: false
-network: {}
----
-
-# Test Workflow
-
-This is a test workflow with empty network permissions (deny all).
-`
-		testFile := filepath.Join(tmpDir, "deny-all-workflow.md")
-		if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
-			t.Fatal(err)
-		}
-
-		// Compile the workflow
-		err := compiler.CompileWorkflow(testFile)
-		if err != nil {
-			t.Fatalf("Unexpected compilation error: %v", err)
-		}
-
-		// Read the compiled output
-		lockFile := filepath.Join(tmpDir, "deny-all-workflow.lock.yml")
-		lockContent, err := os.ReadFile(lockFile)
-		if err != nil {
-			t.Fatalf("Failed to read lock file: %v", err)
-		}
-
-		// Should contain network hook setup (deny-all enforcement)
-		if !strings.Contains(string(lockContent), "Generate Network Permissions Hook") {
-			t.Error("Should contain network hook setup for network: {}")
-		}
-		// Should have empty ALLOWED_DOMAINS array for deny-all
-		if !strings.Contains(string(lockContent), "json.loads('''[]''')") {
-			t.Error("Should have empty ALLOWED_DOMAINS array for deny-all policy")
-		}
-	})
-
-	t.Run("network with allowed domains should enforce restrictions", func(t *testing.T) {
-		testContent := `---
-on: push
-strict: false
-engine:
-  id: claude
-network:
-  allowed: ["example.com", "api.github.com"]
----
-
-# Test Workflow
-
-This is a test workflow with explicit network permissions.
-`
-		testFile := filepath.Join(tmpDir, "allowed-domains-workflow.md")
-		if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
-			t.Fatal(err)
-		}
-
-		// Compile the workflow
-		err := compiler.CompileWorkflow(testFile)
-		if err != nil {
-			t.Fatalf("Unexpected compilation error: %v", err)
-		}
-
-		// Read the compiled output
-		lockFile := filepath.Join(tmpDir, "allowed-domains-workflow.lock.yml")
-		lockContent, err := os.ReadFile(lockFile)
-		if err != nil {
-			t.Fatalf("Failed to read lock file: %v", err)
-		}
-
-		// Should contain network hook setup with specified domains
-		if !strings.Contains(string(lockContent), "Generate Network Permissions Hook") {
-			t.Error("Should contain network hook setup with explicit network permissions")
-		}
-		if !strings.Contains(string(lockContent), `"example.com"`) {
-			t.Error("Should contain example.com in allowed domains")
-		}
-		if !strings.Contains(string(lockContent), `"api.github.com"`) {
-			t.Error("Should contain api.github.com in allowed domains")
-		}
-	})
-
-	t.Run("network permissions with non-claude engine should be ignored", func(t *testing.T) {
-		testContent := `---
-on: push
-engine: codex
-strict: false
-network:
-  allowed: ["example.com"]
----
-
-# Test Workflow
-
-This is a test workflow with network permissions and codex engine.
-`
-		testFile := filepath.Join(tmpDir, "codex-network-workflow.md")
-		if err := os.WriteFile(testFile, []byte(testContent), 0644); err != nil {
-			t.Fatal(err)
-		}
-
-		// Compile the workflow
-		err := compiler.CompileWorkflow(testFile)
-		if err != nil {
-			t.Fatalf("Unexpected compilation error: %v", err)
-		}
-
-		// Read the compiled output
-		lockFile := filepath.Join(tmpDir, "codex-network-workflow.lock.yml")
-		lockContent, err := os.ReadFile(lockFile)
-		if err != nil {
-			t.Fatalf("Failed to read lock file: %v", err)
-		}
-
-		// Should not contain claude-specific network hook setup
-		if strings.Contains(string(lockContent), "Generate Network Permissions Hook") {
-			t.Error("Should not contain network hook setup for non-claude engines")
-		}
-	})
-}
-
 func TestMCPImageField(t *testing.T) {
 	// Create temporary directory for test files
 	tmpDir := testutil.TempDir(t, "mcp-container-test")