Include RA hashes in messages about bad join orders

Author: nickrolfe

extensions/ql-vscode/src/log-insights/join-order.ts

@@ -205,9 +205,10 @@ class JoinOrderScanner {
             resultSize!,
           );
           if (metric >= this.warningThreshold) {
-            const message = `'${
-              event.predicateName
-            }' has an inefficient join order. Its join order metric is ${metric.toFixed(
+            const message = `'${event.predicateName}@${event.raHash.substring(
+              0,
+              8,
+            )}' has an inefficient join order. Its join order metric is ${metric.toFixed(
               2,
             )}, which is larger than the threshold of ${this.warningThreshold.toFixed(
               2,
@@ -243,9 +244,10 @@ class JoinOrderScanner {
                   resultSize,
                 );
                 if (metric >= this.warningThreshold) {
-                  const message = `The ${raReference} pipeline for '${
-                    predicateName
-                  }' has an inefficient join order. Its join order metric is ${metric.toFixed(
+                  const message = `The ${raReference} pipeline for '${predicateName}@${raHash.substring(
+                    0,
+                    8,
+                  )}' has an inefficient join order. Its join order metric is ${metric.toFixed(
                     2,
                   )}, which is larger than the threshold of ${this.warningThreshold.toFixed(
                     2,

extensions/ql-vscode/test/unit-tests/log-scanner.test.ts

@@ -62,7 +62,7 @@ describe("log scanners", () => {
     );
     expect(problemReporter.problems[0].order).toBe("order_500000");
     expect(problemReporter.problems[0].message).toBe(
-      "The order_500000 pipeline for 'Enclosing::exprEnclosingElement#c50c5fbf#ff' has an inefficient join order. Its join order metric is 98.07, which is larger than the threshold of 50.00.",
+      "The order_500000 pipeline for 'Enclosing::exprEnclosingElement#c50c5fbf#ff@7cc60wto' has an inefficient join order. Its join order metric is 98.07, which is larger than the threshold of 50.00.",
     );
 
     expect(problemReporter.problems[1].predicateName).toBe("#select#ff");
@@ -71,7 +71,7 @@ describe("log scanners", () => {
     );
     expect(problemReporter.problems[1].order).toBeUndefined();
     expect(problemReporter.problems[1].message).toBe(
-      "'#select#ff' has an inefficient join order. Its join order metric is 4961.83, which is larger than the threshold of 50.00.",
+      "'#select#ff@1bb43c97' has an inefficient join order. Its join order metric is 4961.83, which is larger than the threshold of 50.00.",
     );
   });
 });