Merge branch 'main' into asgerf/compare-fixes

Author: asgerf

.github/codeql/codeql-config.yml

@@ -8,6 +8,8 @@ queries:
     uses: ./.github/codeql/queries
 paths:
   - ./extensions/ql-vscode
+  - ./.github/workflows
+  - ./.github/actions
 paths-ignore:
   - '**/node_modules'
   - '**/build'

.github/workflows/release.yml

@@ -147,7 +147,7 @@ jobs:
           name: vscode-codeql-extension
 
       - name: Azure User-assigned managed identity login
-        uses: azure/login@v2
+        uses: azure/login@a457da9ea143d694b1b9c7c869ebb04ebe844ef5 # v2.3.0
         with:
           client-id: ${{ secrets.AZURE_CLIENT_ID }}
           tenant-id: ${{ secrets.AZURE_TENANT_ID }}

extensions/ql-vscode/CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## [UNRELEASED]
 
+- Fix reporting of bad join orders in recursive predicates. [#4019](https://github.com/github/vscode-codeql/pull/4019)
+
 ## 1.17.2 - 27 March 2025
 
 - Always authenticate when downloading databases from GitHub, instead of only when in canary mode. [#3941](https://github.com/github/vscode-codeql/pull/3941)

extensions/ql-vscode/gulpfile.ts/textmate.ts

@@ -9,6 +9,7 @@ import type {
   Pattern,
   TextmateGrammar,
 } from "./textmate-grammar";
+import { pipeline } from "stream/promises";
 
 /**
  * Replaces all rule references with the match pattern of the referenced rule.
@@ -276,7 +277,9 @@ export function transpileTextMateGrammar() {
 }
 
 export function compileTextMateGrammar() {
-  return src("syntaxes/*.tmLanguage.yml")
-    .pipe(transpileTextMateGrammar())
-    .pipe(dest("out/syntaxes"));
+  return pipeline(
+    src("syntaxes/*.tmLanguage.yml"),
+    transpileTextMateGrammar(),
+    dest("out/syntaxes"),
+  );
 }

extensions/ql-vscode/gulpfile.ts/typescript.ts

@@ -4,6 +4,7 @@ import esbuild from "gulp-esbuild";
 import type { reporter } from "gulp-typescript";
 import { createProject } from "gulp-typescript";
 import del from "del";
+import { pipeline } from "stream/promises";
 
 export function goodReporter(): reporter.Reporter {
   return {
@@ -37,23 +38,23 @@ export function cleanOutput() {
 }
 
 export function compileEsbuild() {
-  return src("./src/extension.ts")
-    .pipe(
-      esbuild({
-        outfile: "extension.js",
-        bundle: true,
-        external: ["vscode", "fsevents"],
-        format: "cjs",
-        platform: "node",
-        target: "es2020",
-        sourcemap: "linked",
-        sourceRoot: "..",
-        loader: {
-          ".node": "copy",
-        },
-      }),
-    )
-    .pipe(dest("out"));
+  return pipeline(
+    src("./src/extension.ts"),
+    esbuild({
+      outfile: "extension.js",
+      bundle: true,
+      external: ["vscode", "fsevents"],
+      format: "cjs",
+      platform: "node",
+      target: "es2020",
+      sourcemap: "linked",
+      sourceRoot: "..",
+      loader: {
+        ".node": "copy",
+      },
+    }),
+    dest("out"),
+  );
 }
 
 export function watchEsbuild() {

extensions/ql-vscode/gulpfile.ts/view.ts

@@ -3,28 +3,29 @@ import esbuild from "gulp-esbuild";
 import { createProject } from "gulp-typescript";
 import { goodReporter } from "./typescript";
 
+import { pipeline } from "stream/promises";
 import chromiumVersion from "./chromium-version.json";
 
 const tsProject = createProject("src/view/tsconfig.json");
 
 export function compileViewEsbuild() {
-  return src("./src/view/webview.tsx")
-    .pipe(
-      esbuild({
-        outfile: "webview.js",
-        bundle: true,
-        format: "iife",
-        platform: "browser",
-        target: `chrome${chromiumVersion.chromiumVersion}`,
-        jsx: "automatic",
-        sourcemap: "linked",
-        sourceRoot: "..",
-        loader: {
-          ".ttf": "file",
-        },
-      }),
-    )
-    .pipe(dest("out"));
+  return pipeline(
+    src("./src/view/webview.tsx"),
+    esbuild({
+      outfile: "webview.js",
+      bundle: true,
+      format: "iife",
+      platform: "browser",
+      target: `chrome${chromiumVersion.chromiumVersion}`,
+      jsx: "automatic",
+      sourcemap: "linked",
+      sourceRoot: "..",
+      loader: {
+        ".ttf": "file",
+      },
+    }),
+    dest("out"),
+  );
 }
 
 export function watchViewEsbuild() {