Record dependencies inside SCCs

Author: asgerf

extensions/ql-vscode/src/log-insights/log-summary.ts

@@ -30,6 +30,7 @@ interface SummaryEventBase {
 interface ResultEventBase extends SummaryEventBase {
   resultSize: number;
   dependencies?: { [key: string]: string };
+  mainHash?: string;
 }
 
 export interface ComputeSimple extends ResultEventBase {

extensions/ql-vscode/src/log-insights/performance-comparison.ts

@@ -75,6 +75,7 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
     dependencyLists: [],
   };
   private readonly raToIndex = new Map<string, number>();
+  private readonly mainHashToRepr = new Map<string, number>();
   private readonly nameToIndex = new Map<string, number>();
 
   private getPredicateIndex(name: string, ra: string): number {
@@ -207,6 +208,19 @@ export class PerformanceOverviewScanner implements EvaluationLogScanner {
             dependencyList.push(dependencyIndex);
           }
         }
+        // For predicates in the same SCC, add two-way dependencies with an arbitrary SCC member
+        const sccHash =
+          event.mainHash ??
+          (evaluationStrategy === "COMPUTE_RECURSIVE" ? raHash : null);
+        if (sccHash != null) {
+          const mainIndex = this.mainHashToRepr.get(sccHash);
+          if (mainIndex == null) {
+            this.mainHashToRepr.set(sccHash, index);
+          } else {
+            dependencyLists[index].push(mainIndex);
+            dependencyLists[mainIndex].push(index);
+          }
+        }
         timeCosts[index] += totalTime;
         tupleCosts[index] += totalTuples;
         iterationCounts[index] += event.pipelineRuns?.length ?? 0;