Skip to content

Commit 438c0ba

Browse files
committed
Fix linter issues
1 parent 5c5980c commit 438c0ba

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

extensions/ql-vscode/src/compare-performance/compare-performance-view.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { PerformanceOverviewScanner } from "../log-insights/performance-comparis
1919
import type { ResultsView } from "../local-queries";
2020
import { readJsonlFile } from "../common/jsonl-reader";
2121
import type { SummaryEvent } from "../log-insights/log-summary";
22-
import { CompletedLocalQueryInfo } from "../query-results";
22+
import type { CompletedLocalQueryInfo } from "../query-results";
2323

2424
export class ComparePerformanceView extends AbstractWebview<
2525
ToComparePerformanceViewMessage,
@@ -40,19 +40,19 @@ export class ComparePerformanceView extends AbstractWebview<
4040
) {
4141
if (to === undefined) {
4242
// For single-run comparisons, the performance viewer considers the 'from' side to be missing.
43-
this.showResultsAux(undefined, from);
43+
return this.showResultsAux(undefined, from);
4444
} else {
45-
this.showResultsAux(from, to);
45+
return this.showResultsAux(from, to);
4646
}
4747
}
4848

4949
private async showResultsAux(
5050
from: CompletedLocalQueryInfo | undefined,
5151
to: CompletedLocalQueryInfo,
5252
) {
53-
let fromJsonLog =
53+
const fromJsonLog =
5454
from === undefined ? "" : from?.evaluatorLogPaths?.jsonSummary;
55-
let toJsonLog = to?.evaluatorLogPaths?.jsonSummary;
55+
const toJsonLog = to?.evaluatorLogPaths?.jsonSummary;
5656

5757
if (fromJsonLog === undefined || toJsonLog === undefined) {
5858
return extLogger.showWarningMessage(

0 commit comments

Comments
 (0)