Merge pull request #149 from jhrcek/warnings-in-tests

Enable warnings in tests

Author: Patrick Thomson

semantic.cabal

@@ -73,8 +73,11 @@ common dependencies
 common executable-flags
   ghc-options:         -threaded -rtsopts "-with-rtsopts=-N -A4m -n2m"
 
+common ghc-warnings
+  ghc-options:         -Wall -Wmissing-export-lists -Wcompat -Wincomplete-record-updates -Wincomplete-uni-patterns -Wredundant-constraints -Wno-name-shadowing
+
 library
-  import:              haskell, dependencies
+  import:              haskell, dependencies, ghc-warnings
   hs-source-dirs:      src
   exposed-modules:
                      -- Analyses & term annotations
@@ -321,7 +324,6 @@ library
                      , tree-sitter-typescript ^>= 0.1.0.0
                      , tree-sitter-tsx ^>= 0.1.0.0
                      , tree-sitter-java ^>= 0.1.0.0
-  ghc-options:         -Wall -Wmissing-export-lists -Wcompat -Wincomplete-record-updates -Wincomplete-uni-patterns -Wredundant-constraints -fno-warn-name-shadowing
   if flag(release)
     cpp-options:       -DCOMPUTE_GIT_SHA
   else
@@ -337,10 +339,9 @@ executable semantic
                      , semantic
 
 test-suite test
-  import:              haskell, dependencies, executable-flags
+  import:              haskell, dependencies, executable-flags, ghc-warnings
   type:                exitcode-stdio-1.0
   hs-source-dirs:      test
-  ghc-options:         -Wunused-imports
   main-is:             Spec.hs
   other-modules:       Analysis.Go.Spec
                      , Analysis.PHP.Spec

src/Data/Language.hs

@@ -13,8 +13,6 @@ module Data.Language
   ) where
 
 import           Data.Aeson
-import           Data.Char (toUpper)
-import           Data.String
 import qualified Data.Text as T
 import           Prologue
 import           System.FilePath.Posix

test/Rendering/TOC/Spec.hs

@@ -225,15 +225,13 @@ blankDiff = merge (Nothing, Nothing) (inject [ inserting (termIn Nothing (inject
 
 -- Diff helpers
 diffWithParser :: ( Eq1 syntax
-                  , Show1 syntax
                   , Traversable syntax
                   , Diffable syntax
                   , HasDeclaration syntax
                   , Hashable1 syntax
                   , Member Distribute sig
                   , Member Task sig
                   , Carrier sig m
-                  , Monad m
                   )
                => Parser (Term syntax Location)
                -> BlobPair

test/Reprinting/Spec.hs

@@ -2,12 +2,12 @@
 
 module Reprinting.Spec where
 
-import SpecHelpers hiding (inject, project)
+import SpecHelpers
 
 import           Data.Foldable
 import qualified Data.Machine as Machine
 
-import           Control.Rewriting hiding (context)
+import           Control.Rewriting
 import qualified Data.Language as Language
 import           Data.Reprinting.Scope
 import           Data.Reprinting.Token

test/SpecHelpers.hs

@@ -19,15 +19,15 @@ module SpecHelpers
 , EdgeLabel(..)
 ) where
 
-import Control.Abstract hiding (lookupDeclaration)
+import Control.Abstract
 import Data.Abstract.ScopeGraph (EdgeLabel(..))
 import qualified Data.Abstract.ScopeGraph as ScopeGraph
 import qualified Data.Abstract.Heap as Heap
 import Control.Effect.Trace as X (runTraceByIgnoring, runTraceByReturning)
 import Control.Monad ((>=>))
 import Data.Traversable as X (for)
 import Data.Abstract.Address.Precise as X
-import Data.Abstract.Evaluatable hiding (lookupDeclaration)
+import Data.Abstract.Evaluatable
 import Data.Abstract.FreeVariables as X
 import Data.Abstract.Module as X
 import Data.Abstract.ModuleTable as X hiding (lookup)
@@ -51,7 +51,7 @@ import Data.String
 import Data.Sum
 import Data.Term as X
 import Parsing.Parser as X
-import Semantic.Task as X hiding (parsePackage)
+import Semantic.Task as X
 import Semantic.Util as X
 import Semantic.Graph (runHeap, runScopeGraph)
 import System.FilePath as X