NoProgressMeter: change type into a variable

mhagger · mhagger · commit 141b75c064b9 · 2021-11-07T16:56:43.000+01:00
This makes it easier for other modules to use.
diff --git a/meter/meter.go b/meter/meter.go
@@ -105,9 +105,11 @@ func (p *progressMeter) Done() {
 
 // NoProgressMeter is a `Progress` that doesn't actually report
 // anything.
-type NoProgressMeter struct{}
+var NoProgressMeter noProgressMeter
 
-func (p *NoProgressMeter) Start(string) {}
-func (p *NoProgressMeter) Inc()         {}
-func (p *NoProgressMeter) Add(int64)    {}
-func (p *NoProgressMeter) Done()        {}
+type noProgressMeter struct{}
+
+func (p noProgressMeter) Start(string) {}
+func (p noProgressMeter) Inc()         {}
+func (p noProgressMeter) Add(int64)    {}
+func (p noProgressMeter) Done()        {}
diff --git a/sizes/graph.go b/sizes/graph.go
@@ -72,7 +72,7 @@ func ScanRepositoryUsingGraph(
 	if progress {
 		progressMeter = meter.NewProgressMeter(100 * time.Millisecond)
 	} else {
-		progressMeter = &meter.NoProgressMeter{}
+		progressMeter = meter.NoProgressMeter
 	}
 
 	refIter, err := repo.NewReferenceIter()

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ func ScanRepositoryUsingGraph(`
`72`	`72`	`if progress {`
`73`	`73`	`progressMeter = meter.NewProgressMeter(100 * time.Millisecond)`
`74`	`74`	`} else {`
`75`		`- progressMeter = &meter.NoProgressMeter{}`
	`75`	`+ progressMeter = meter.NoProgressMeter`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`refIter, err := repo.NewReferenceIter()`