refactor: reduce Validate() complexity to resolve CA1502 warning

Author: AakashSuresh2003

src/OctoshiftCLI.Tests/gei/Commands/MigrateRepo/MigrateRepoCommandArgsTests.cs

@@ -317,8 +317,6 @@ public void It_Throws_Error_When_Url_Provided_In_GithubSourceOrg()
                 GithubSourceOrg = "https://github.com/foo",
                 GithubTargetOrg = TARGET_ORG,
                 TargetRepo = TARGET_REPO,
-                MetadataArchiveUrl = METADATA_ARCHIVE_URL,
-                MetadataArchivePath = METADATA_ARCHIVE_PATH
             };
             FluentActions.Invoking(() => args.Validate(_mockOctoLogger.Object))
                 .Should()
@@ -334,8 +332,6 @@ public void It_Throws_Error_When_Url_Provided_In_GithubTargetOrg()
                 GithubSourceOrg = SOURCE_ORG,
                 GithubTargetOrg = "https://github.com/bar",
                 TargetRepo = TARGET_REPO,
-                MetadataArchiveUrl = METADATA_ARCHIVE_URL,
-                MetadataArchivePath = METADATA_ARCHIVE_PATH
             };
             FluentActions.Invoking(() => args.Validate(_mockOctoLogger.Object))
                 .Should()
@@ -351,8 +347,6 @@ public void It_Throws_Error_When_Url_Provided_In_Both_Source_And_Target_Org()
                 GithubSourceOrg = "https://github.com/foo",
                 GithubTargetOrg = "https://github.com/bar",
                 TargetRepo = TARGET_REPO,
-                MetadataArchiveUrl = METADATA_ARCHIVE_URL,
-                MetadataArchivePath = METADATA_ARCHIVE_PATH
             };
             FluentActions.Invoking(() => args.Validate(_mockOctoLogger.Object))
                 .Should()
@@ -368,8 +362,6 @@ public void It_Throws_Error_When_Url_Provided_In_SourceRepo()
                 GithubSourceOrg = SOURCE_ORG,
                 GithubTargetOrg = TARGET_ORG,
                 TargetRepo = TARGET_REPO,
-                MetadataArchiveUrl = METADATA_ARCHIVE_URL,
-                MetadataArchivePath = METADATA_ARCHIVE_PATH
             };
             FluentActions.Invoking(() => args.Validate(_mockOctoLogger.Object))
                 .Should()
@@ -385,8 +377,6 @@ public void It_Throws_Error_When_Url_Provided_In_TargetRepo()
                 GithubSourceOrg = SOURCE_ORG,
                 GithubTargetOrg = TARGET_ORG,
                 TargetRepo = "https://github.com/bar",
-                MetadataArchiveUrl = METADATA_ARCHIVE_URL,
-                MetadataArchivePath = METADATA_ARCHIVE_PATH
             };  
             FluentActions.Invoking(() => args.Validate(_mockOctoLogger.Object))
                 .Should()

src/gei/Commands/MigrateRepo/MigrateRepoCommandArgs.cs

@@ -45,25 +45,6 @@ public override void Validate(OctoLogger log)
             DefaultSourcePat(log);
             DefaultTargetRepo(log);
 
-            if (!string.IsNullOrWhiteSpace(GithubSourceOrg) && Uri.IsWellFormedUriString(GithubSourceOrg, UriKind.Absolute))
-            {
-                throw new OctoshiftCliException("GithubSourceOrg should be an org name, not a URL.");
-            }
-
-            if (!string.IsNullOrWhiteSpace(GithubTargetOrg) && Uri.IsWellFormedUriString(GithubTargetOrg, UriKind.Absolute))
-            {
-                throw new OctoshiftCliException("GithubTargetOrg should be an org name, not a URL.");
-            }
-
-            if (!string.IsNullOrWhiteSpace(SourceRepo) && Uri.IsWellFormedUriString(SourceRepo, UriKind.Absolute))
-            {
-                throw new OctoshiftCliException("SourceRepo should be a repo name, not a URL.");
-            }
-
-            if (!string.IsNullOrWhiteSpace(TargetRepo) && Uri.IsWellFormedUriString(TargetRepo, UriKind.Absolute))
-            {
-                throw new OctoshiftCliException("TargetRepo should be a repo name, not a URL.");
-            }
             if (GitArchiveUrl.HasValue() && GitArchivePath.HasValue())
             {
                 throw new OctoshiftCliException("The options --git-archive-url and --git-archive-path may not be used together");
@@ -116,6 +97,7 @@ public override void Validate(OctoLogger log)
             {
                 throw new OctoshiftCliException("The --use-github-storage flag was provided with a connection string for an Azure storage account. Archive cannot be uploaded to both locations.");
             }
+            ValidateOrgAndRepoNames(); return; 
         }
 
         private void DefaultTargetRepo(OctoLogger log)
@@ -135,5 +117,19 @@ private void DefaultSourcePat(OctoLogger log)
                 log?.LogInformation("Since github-target-pat is provided, github-source-pat will also use its value.");
             }
         }
+        private void ValidateOrgAndRepoNames()
+        {
+            if (!string.IsNullOrWhiteSpace(GithubSourceOrg) && Uri.IsWellFormedUriString(GithubSourceOrg, UriKind.Absolute))
+                throw new OctoshiftCliException("GithubSourceOrg should be an org name, not a URL.");
+
+            if (!string.IsNullOrWhiteSpace(GithubTargetOrg) && Uri.IsWellFormedUriString(GithubTargetOrg, UriKind.Absolute))
+                throw new OctoshiftCliException("GithubTargetOrg should be an org name, not a URL.");
+
+            if (!string.IsNullOrWhiteSpace(SourceRepo) && Uri.IsWellFormedUriString(SourceRepo, UriKind.Absolute))
+                throw new OctoshiftCliException("SourceRepo should be a repo name, not a URL.");
+
+            if (!string.IsNullOrWhiteSpace(TargetRepo) && Uri.IsWellFormedUriString(TargetRepo, UriKind.Absolute))
+                throw new OctoshiftCliException("TargetRepo should be a repo name, not a URL.");
+        }
     }
 }