Skip to content

Commit 2e6bf6b

Browse files
authored
Fix superscripts floating above sticky table headers (#57661)
1 parent 9a58c7c commit 2e6bf6b

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

src/frame/components/page-header/Header.module.scss

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,6 @@
66
display: unset;
77
}
88

9-
// Need children of portal root to be higher z-index to show dropdown
10-
.portalRoot * {
11-
z-index: 3 !important;
12-
}
13-
149
// Contains the logo and version picker and used when the smaller width search
1510
// input UI is closed.
1611
.logoWithClosedSearch {

src/frame/components/page-header/Header.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ export const Header = () => {
149149
{error !== '404' && <HeaderNotifications />}
150150
<header
151151
className={cx(
152-
'color-bg-default p-2 position-sticky top-0 z-1 border-bottom',
152+
'color-bg-default p-2 position-sticky top-0 z-2 border-bottom',
153153
scroll && 'color-shadow-small',
154154
)}
155155
role="banner"

src/frame/components/ui/MarkdownContent/stylesheets/table.scss

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
thead {
3636
position: sticky;
3737
top: 105px; // 88 + 8 + 8 + 1, space for the site header
38+
z-index: 1; // Ensure header stays above content including superscripts
3839

3940
@include breakpoint-xxl {
4041
top: 65px !important; // 48 + 8 + 8 + 1, space for the site header

src/frame/stylesheets/dialog-overrides.scss

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,3 +10,8 @@
1010
visibility: hidden !important;
1111
}
1212
}
13+
14+
// Fix z-index for ActionMenu overlays (version picker, etc.) to appear above site header
15+
#__primerPortalRoot__ * {
16+
z-index: 3 !important;
17+
}

0 commit comments

Comments
 (0)