C#: Address review comments.

michaelnebel · michaelnebel · commit fe4ec59b4ee3 · 2025-01-02T11:21:29.000+01:00
diff --git a/csharp/ql/lib/semmle/code/csharp/commons/Collections.qll b/csharp/ql/lib/semmle/code/csharp/commons/Collections.qll
@@ -79,14 +79,14 @@ abstract private class ParamsCollectionTypeImpl extends ValueOrRefType {
   abstract Type getElementType();
 }
 
-private class AddArrayType extends ParamsCollectionTypeImpl instanceof ArrayType {
+private class ParamsArrayType extends ParamsCollectionTypeImpl instanceof ArrayType {
   override Type getElementType() { result = ArrayType.super.getElementType() }
 }
 
-private class AddCollectionTypes extends ParamsCollectionTypeImpl {
+private class ParamsConstructedCollectionTypes extends ParamsCollectionTypeImpl {
   private ConstructedType base;
 
-  AddCollectionTypes() {
+  ParamsConstructedCollectionTypes() {
     exists(UnboundGenericType unboundbase |
       base = this.getABaseType*() and unboundbase = base.getUnboundGeneric()
     |

Original file line number	Diff line number	Diff line change
`@@ -79,14 +79,14 @@ abstract private class ParamsCollectionTypeImpl extends ValueOrRefType {`
`79`	`79`	`abstract Type getElementType();`
`80`	`80`	`}`
`81`	`81`
`82`		`-private class AddArrayType extends ParamsCollectionTypeImpl instanceof ArrayType {`
	`82`	`+private class ParamsArrayType extends ParamsCollectionTypeImpl instanceof ArrayType {`
`83`	`83`	`override Type getElementType() { result = ArrayType.super.getElementType() }`
`84`	`84`	`}`
`85`	`85`
`86`		`-private class AddCollectionTypes extends ParamsCollectionTypeImpl {`
	`86`	`+private class ParamsConstructedCollectionTypes extends ParamsCollectionTypeImpl {`
`87`	`87`	`private ConstructedType base;`
`88`	`88`
`89`		`- AddCollectionTypes() {`
	`89`	`+ ParamsConstructedCollectionTypes() {`
`90`	`90`	`exists(UnboundGenericType unboundbase \|`
`91`	`91`	`base = this.getABaseType*() and unboundbase = base.getUnboundGeneric()`
`92`	`92`	`\|`