Rust: Fix typo in model.

Author: geoffw0

rust/ql/lib/codeql/rust/frameworks/async-rs.model.yml

@@ -3,4 +3,4 @@ extensions:
       pack: codeql/rust-all
       extensible: sourceModel
     data:
-      - ["<async-std::net::tcp::stream::TcpStream>::connect", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"]
+      - ["<async_std::net::tcp::stream::TcpStream>::connect", "ReturnValue.Future.Field[core::result::Result::Ok(0)]", "remote", "manual"]

rust/ql/test/library-tests/dataflow/sources/TaintSources.expected

@@ -75,6 +75,7 @@
 | test.rs:779:22:779:50 | ...::new | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | test.rs:806:16:806:29 | ...::args | Flow source 'CommandLineArgs' of type commandargs (DEFAULT). |
 | test.rs:806:16:806:29 | ...::args | Flow source 'CommandLineArgs' of type commandargs (DEFAULT). |
+| test_futures_io.rs:19:15:19:32 | ...::connect | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:11:31:11:31 | a | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:11:31:11:31 | a | Flow source 'RemoteSource' of type remote (DEFAULT). |
 | web_frameworks.rs:22:14:22:18 | TuplePat | Flow source 'RemoteSource' of type remote (DEFAULT). |

rust/ql/test/library-tests/dataflow/sources/test_futures_io.rs

@@ -16,21 +16,21 @@ use std::task::{Context, Poll};
 
 async fn test_futures_rustls_futures_io() -> io::Result<()> {
     let url = "www.example.com:443";
-    let tcp = TcpStream::connect(url).await?; // $ MISSING: Alert[rust/summary/taint-sources]
-    sink(&tcp); // $ MISSING: hasTaintFlow=url
+    let tcp = TcpStream::connect(url).await?; // $ Alert[rust/summary/taint-sources]
+    sink(&tcp); // $ hasTaintFlow=url
     let config = rustls::ClientConfig::builder()
         .with_root_certificates(rustls::RootCertStore::empty())
         .with_no_client_auth();
     let connector = TlsConnector::from(Arc::new(config));
     let server_name = rustls::pki_types::ServerName::try_from("www.example.com").unwrap();
     let mut reader = connector.connect(server_name, tcp).await?;
-    sink(&reader); // $ MISSING: hasTaintFlow=url
+    sink(&reader); // $ hasTaintFlow=url
 
     {
         // using the `AsyncRead` trait (low-level)
         let mut buffer = [0u8; 64];
         let mut pinned = Pin::new(&mut reader);
-        sink(&pinned); // $ MISSING: hasTaintFlow=url
+        sink(&pinned); // $ hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let bytes_read = pinned.poll_read(&mut cx, &mut buffer); // we cannot correctly resolve this call, since it relies on `Deref`
         if let Poll::Ready(Ok(n)) = bytes_read {
@@ -52,12 +52,12 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
     }
 
     let mut reader2 = futures::io::BufReader::new(reader);
-    sink(&reader2); // $ MISSING: hasTaintFlow=url
+    sink(&reader2); // $ hasTaintFlow=url
 
     {
         // using the `AsyncBufRead` trait (low-level)
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ MISSING: hasTaintFlow=url
+        sink(&pinned); // $ hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let buffer = pinned.poll_fill_buf(&mut cx);
         if let Poll::Ready(Ok(buf)) = buffer {
@@ -88,7 +88,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
         // using the `AsyncRead` trait (low-level)
         let mut buffer = [0u8; 64];
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ MISSING: hasTaintFlow=url
+        sink(&pinned); // $ hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let bytes_read = pinned.poll_read(&mut cx, &mut buffer);
         sink(&buffer); // $ MISSING: hasTaintFlow=url
@@ -111,7 +111,7 @@ async fn test_futures_rustls_futures_io() -> io::Result<()> {
     {
         // using the `AsyncBufRead` trait (low-level)
         let mut pinned = Pin::new(&mut reader2);
-        sink(&pinned); // $ MISSING: hasTaintFlow=url
+        sink(&pinned); // $ hasTaintFlow=url
         let mut cx = Context::from_waker(futures::task::noop_waker_ref());
         let buffer = pinned.poll_fill_buf(&mut cx);
         sink(&buffer); // $ MISSING: hasTaintFlow=url