Improve value flow through arrays

owen-mc · owen-mc · commit ed349f7d6b42 · 2023-11-13T23:26:16.000Z
diff --git a/go/ql/lib/semmle/go/dataflow/internal/ContainerFlow.qll b/go/ql/lib/semmle/go/dataflow/internal/ContainerFlow.qll
@@ -21,7 +21,7 @@ predicate containerStoreStep(Node node1, Node node2, Content c) {
       node2.getType() instanceof SliceType
     ) and
     (
-      exists(Write w | w.writesElement(node2, _, node1))
+      exists(Write w | w.writesElement(node2.(PostUpdateNode).getPreUpdateNode(), _, node1))
       or
       node1 = node2.(ImplicitVarargsSlice).getCallNode().getAnImplicitVarargsArgument()
     )

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ predicate containerStoreStep(Node node1, Node node2, Content c) {`
`21`	`21`	`node2.getType() instanceof SliceType`
`22`	`22`	`) and`
`23`	`23`	`(`
`24`		`- exists(Write w \| w.writesElement(node2, _, node1))`
	`24`	`+ exists(Write w \| w.writesElement(node2.(PostUpdateNode).getPreUpdateNode(), _, node1))`
`25`	`25`	`or`
`26`	`26`	`node1 = node2.(ImplicitVarargsSlice).getCallNode().getAnImplicitVarargsArgument()`
`27`	`27`	`)`