Merge pull request #7575 from github/henrymercer/atm-remove-code-to-features

JS: Remove ATM `CodeToFeatures` library

Author: henrymercer

javascript/ql/experimental/adaptivethreatmodeling/lib/experimental/adaptivethreatmodeling/BaseScoring.qll

@@ -14,73 +14,6 @@ external predicate availableMlModels(
 /** Get the ATM configuration. */
 ATMConfig getCfg() { any() }
 
-/**
- * This module provides functionality that takes an endpoint and provides an entity that encloses that
- * endpoint and is suitable for similarity analysis.
- */
-module EndpointToEntity {
-  private import CodeToFeatures
-
-  /**
-   * Get an entity enclosing the endpoint that is suitable for similarity analysis. In general,
-   * this may associate multiple entities to a single endpoint.
-   */
-  DatabaseFeatures::Entity getAnEntityForEndpoint(DataFlow::Node endpoint) {
-    DatabaseFeatures::entities(result, _, _, _, _, _, _, _, _) and
-    result.getDefinedFunction() = endpoint.getContainer().getEnclosingContainer*()
-  }
-}
-
-/**
- * This module provides functionality that takes an entity and provides effective endpoints within
- * that entity.
- *
- * We use the following terminology to describe endpoints:
- *
- * - The *candidate* endpoints are the set of data flow nodes that should be passed to the
- *   appropriate endpoint filter to produce the set of effective endpoints.
- *   When we have a model that beats the performance of the baseline, we will likely define the
- *   candidate endpoints based on the most confident predictions of the model.
- * - An *effective* endpoint is a candidate endpoint which passes through the endpoint filter.
- *   In other words, it is a candidate endpoint for which the `isEffectiveSink` (or
- *   `isEffectiveSource`) predicate defined in the `ATMConfig` instance in scope holds.
- */
-module EntityToEffectiveEndpoint {
-  private import CodeToFeatures
-
-  /**
-   * Returns endpoint candidates within the specified entities.
-   *
-   * The baseline implementation of this is that a candidate endpoint is any data flow node that is
-   * enclosed within the specified entity.
-   */
-  private DataFlow::Node getABaselineEndpointCandidate(DatabaseFeatures::Entity entity) {
-    result.getContainer().getEnclosingContainer*() = entity.getDefinedFunction()
-  }
-
-  /**
-   * Get an effective source enclosed by the specified entity.
-   *
-   * N.B. This is _not_ an inverse of `EndpointToEntity::getAnEntityForEndpoint`: the effective
-   * source may occur in a function defined within the specified entity.
-   */
-  DataFlow::Node getAnEffectiveSource(DatabaseFeatures::Entity entity) {
-    result = getABaselineEndpointCandidate(entity) and
-    getCfg().isEffectiveSource(result)
-  }
-
-  /**
-   * Get an effective sink enclosed by the specified entity.
-   *
-   * N.B. This is _not_ an inverse of `EndpointToEntity::getAnEntityForEndpoint`: the effective
-   * sink may occur in a function defined within the specified entity.
-   */
-  DataFlow::Node getAnEffectiveSink(DatabaseFeatures::Entity entity) {
-    result = getABaselineEndpointCandidate(entity) and
-    getCfg().isEffectiveSink(result)
-  }
-}
-
 /**
  * Scoring information produced by a scoring model.
  *