Use code-quality-selectors in Ruby suite

tamasvajk · tamasvajk · commit e9e6d68a6eba · 2025-04-29T16:23:33.000+02:00
diff --git a/ruby/ql/integration-tests/query-suite/ruby-code-quality.qls.expected b/ruby/ql/integration-tests/query-suite/ruby-code-quality.qls.expected
@@ -1,3 +1,2 @@
 ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql
-ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql
 ql/ruby/ql/src/queries/variables/UninitializedLocal.ql
diff --git a/ruby/ql/src/codeql-suites/ruby-code-quality.qls b/ruby/ql/src/codeql-suites/ruby-code-quality.qls
@@ -1,6 +1,3 @@
 - queries: .
-- include:
-    id:
-      - rb/database-query-in-loop
-      - rb/useless-assignment-to-local
-      - rb/uninitialized-local-variable
+- apply: code-quality-selectors.yml
+  from: codeql/suite-helpers
diff --git a/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql b/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql
@@ -6,6 +6,7 @@
  * @precision high
  * @id rb/database-query-in-loop
  * @tags performance
+ *       quality
  */
 
 import ruby
diff --git a/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql b/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql
@@ -6,6 +6,7 @@
  * @problem.severity warning
  * @id rb/useless-assignment-to-local
  * @tags maintainability
+ *       quality
  *       external/cwe/cwe-563
  * @precision medium
  */

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,2 @@`
`1`	`1`	`ql/ruby/ql/src/queries/performance/DatabaseQueryInLoop.ql`
`2`		`-ql/ruby/ql/src/queries/variables/DeadStoreOfLocal.ql`
`3`	`2`	`ql/ruby/ql/src/queries/variables/UninitializedLocal.ql`