Merge pull request #20243 from hvitved/rust/canonical-path-transitive-deps

hvitved · web-flow · commit e6150e207950 · 2025-08-19T09:46:53.000+02:00
Rust: Take transitive dependencies into account when computing canonical paths
diff --git a/rust/ql/lib/codeql/rust/internal/PathResolution.qll b/rust/ql/lib/codeql/rust/internal/PathResolution.qll
@@ -615,7 +615,7 @@ class ImplItemNode extends ImplOrTraitItemNode instanceof Impl {
       if this.hasCanonicalPath(c2)
       then c1 = c2
       else (
-        c2 = c1.getADependency() or c1 = c2.getADependency()
+        c2 = c1.getADependency+() or c1 = c2.getADependency+()
       )
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -615,7 +615,7 @@ class ImplItemNode extends ImplOrTraitItemNode instanceof Impl {`
`615`	`615`	`if this.hasCanonicalPath(c2)`
`616`	`616`	`then c1 = c2`
`617`	`617`	`else (`
`618`		`- c2 = c1.getADependency() or c1 = c2.getADependency()`
	`618`	`+ c2 = c1.getADependency+() or c1 = c2.getADependency+()`
`619`	`619`	`)`
`620`	`620`	`)`
`621`	`621`	`}`