Merge pull request #17002 from Flying-Tom/add-get-response

joefarebrother · web-flow · commit e47d4ccb7923 · 2024-08-06T09:44:21.000+01:00
Ruby: Add get_response for Net::HTTP
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/http_clients/NetHttp.qll b/ruby/ql/lib/codeql/ruby/frameworks/http_clients/NetHttp.qll
@@ -29,7 +29,7 @@ class NetHttpRequest extends Http::Client::Request::Range, DataFlow::CallNode {
       this = request
     |
       // Net::HTTP.get(...)
-      method = "get" and
+      method in ["get", "get_response"] and
       requestNode = API::getTopLevelMember("Net").getMember("HTTP").getReturn(method) and
       returnsResponseBody = true
       or

Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ class NetHttpRequest extends Http::Client::Request::Range, DataFlow::CallNode {`
`29`	`29`	`this = request`
`30`	`30`	`\|`
`31`	`31`	`// Net::HTTP.get(...)`
`32`		`- method = "get" and`
	`32`	`+ method in ["get", "get_response"] and`
`33`	`33`	`requestNode = API::getTopLevelMember("Net").getMember("HTTP").getReturn(method) and`
`34`	`34`	`returnsResponseBody = true`
`35`	`35`	`or`