Rust: Add more unreachable test cases.

Author: geoffw0

rust/ql/test/query-tests/unusedentities/UnreachableCode.expected

@@ -10,5 +10,11 @@
 | unreachable.rs:147:3:147:17 | ExprStmt | This code is never reached. |
 | unreachable.rs:156:4:156:18 | ExprStmt | This code is never reached. |
 | unreachable.rs:162:3:162:17 | ExprStmt | This code is never reached. |
+| unreachable.rs:168:4:168:18 | ExprStmt | This code is never reached. |
 | unreachable.rs:176:4:176:18 | ExprStmt | This code is never reached. |
 | unreachable.rs:179:2:179:16 | ExprStmt | This code is never reached. |
+| unreachable.rs:193:3:193:17 | ExprStmt | This code is never reached. |
+| unreachable.rs:196:2:196:16 | ExprStmt | This code is never reached. |
+| unreachable.rs:201:3:201:17 | ExprStmt | This code is never reached. |
+| unreachable.rs:216:2:216:16 | ExprStmt | This code is never reached. |
+| unreachable.rs:225:2:225:16 | ExprStmt | This code is never reached. |

rust/ql/test/query-tests/unusedentities/main.rs

@@ -456,9 +456,13 @@ fn main() {
     func_ptrs();
     folds_and_closures();
 
-	unreachable_if();
+	unreachable_if_1();
 	unreachable_panic();
 	unreachable_match();
 	unreachable_loop();
 	unreachable_paren();
+	unreachable_let_1();
+	unreachable_let_2();
+	unreachable_if_2();
+	unreachable_if_3();
 }

rust/ql/test/query-tests/unusedentities/unreachable.rs

@@ -7,7 +7,7 @@
 fn do_something() {
 }
 
-fn unreachable_if() {
+fn unreachable_if_1() {
 	if false {
 		do_something(); // BAD: unreachable code
 	} else {
@@ -162,13 +162,13 @@ fn unreachable_loop() {
 		do_something(); // BAD: unreachable code
 	}
 
-
-
-
-
-
-
-
+	for x in 1..10 {
+		if cond() {
+			continue;
+			do_something(); // BAD: unreachable code
+		}
+		do_something();
+	}
 
 	loop {
 		if cond() {
@@ -184,3 +184,43 @@ fn unreachable_loop() {
 fn unreachable_paren() {
 	let _ = (((1)));
 }
+
+fn unreachable_let_1() {
+	if let a = get_a_number() {
+		do_something();
+		return;
+	} else {
+		do_something(); // SPURIOUS: unreachable code
+	}
+
+	do_something(); // SPURIOUS: unreachable code
+}
+
+fn unreachable_let_2() {
+	let a = get_a_number() else {
+		do_something(); // SPURIOUS: unreachable code
+		return;
+	};
+
+	do_something();
+}
+
+fn unreachable_if_2() {
+	if cond() {
+		do_something();
+		return;
+	} else {
+		do_something();
+	}
+
+	do_something(); // SPURIOUS: unreachable code
+}
+
+fn unreachable_if_3() {
+	if !cond() {
+		do_something();
+		return;
+	}
+
+	do_something(); // SPURIOUS: unreachable code
+}