Java: convert ImproperIntentVerification test to .qlref

d10c · d10c · commit e0311e26c6ab · 2025-06-24T16:42:35.000+02:00
It's a non-path query, so the InlineExpectationsTest postprocessor doesn't do anything.
diff --git a/java/ql/test/query-tests/security/CWE-925/BootReceiverXml.java b/java/ql/test/query-tests/security/CWE-925/BootReceiverXml.java
@@ -6,8 +6,8 @@
 class BootReceiverXml extends BroadcastReceiver {
     void doStuff(Intent intent) {}
 
-    @Override 
-    public void onReceive(Context ctx, Intent intent) { // $hasResult
+    @Override
+    public void onReceive(Context ctx, Intent intent) { // $ Alert
         doStuff(intent);
     }
-}
+}
diff --git a/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.expected b/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.expected
@@ -0,0 +1 @@
+| BootReceiverXml.java:10:17:10:25 | onReceive | This reciever doesn't verify intents it receives, and $@ to receive $@. | AndroidManifest.xml:3:9:7:20 | receiver | it is registered | AndroidManifest.xml:5:17:5:79 | action | the system action action |
diff --git a/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.ql b/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.ql
diff --git a/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.qlref b/java/ql/test/query-tests/security/CWE-925/ImproperIntentVerification.qlref
@@ -0,0 +1,4 @@
+query: Security/CWE/CWE-925/ImproperIntentVerification.ql
+postprocess:
+  - utils/test/PrettyPrintModels.ql
+  - utils/test/InlineExpectationsTestQuery.ql

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+\| BootReceiverXml.java:10:17:10:25 \| onReceive \| This reciever doesn't verify intents it receives, and $@ to receive $@. \| AndroidManifest.xml:3:9:7:20 \| receiver \| it is registered \| AndroidManifest.xml:5:17:5:79 \| action \| the system action action \|`