Skip to content

Commit d5ee91b

Browse files
author
Alex Eyers-Taylor
committed
Java: Adress comments form code review.
1 parent dcc5572 commit d5ee91b

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

java/ql/lib/semmle/code/java/dataflow/SSA.qll

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -253,11 +253,11 @@ class SsaImplicitUpdate extends SsaUpdate {
253253
or
254254
if this.hasImplicitQualifierUpdate()
255255
then
256-
if isNonNonLocal(this)
256+
if isNonLocal(this)
257257
then result = "nonlocal + nonlocal qualifier"
258258
else result = "nonlocal qualifier"
259259
else (
260-
isNonNonLocal(this) and result = "nonlocal"
260+
isNonLocal(this) and result = "nonlocal"
261261
)
262262
}
263263

@@ -289,9 +289,9 @@ class SsaImplicitUpdate extends SsaUpdate {
289289
}
290290

291291
overlay[global]
292-
private predicate isNonNonLocalImpl(SsaImplicitUpdate su) { exists(su.getANonLocalUpdate()) }
292+
private predicate isNonLocalImpl(SsaImplicitUpdate su) { exists(su.getANonLocalUpdate()) }
293293

294-
private predicate isNonNonLocal(SsaImplicitUpdate su) = forceLocal(isNonNonLocalImpl/1)(su)
294+
private predicate isNonLocal(SsaImplicitUpdate su) = forceLocal(isNonLocalImpl/1)(su)
295295

296296
/**
297297
* An SSA variable that represents an uncertain implicit update of the value.

java/ql/lib/semmle/code/java/dataflow/internal/SsaImpl.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -555,7 +555,6 @@ private module Cached {
555555
Impl::phiHasInputFromBlock(phi, inp, bb)
556556
}
557557

558-
overlay[global]
559558
cached
560559
module DataFlowIntegration {
561560
import DataFlowIntegrationImpl

0 commit comments

Comments
 (0)