Rust: Use extractor resolution in call resolution telemetry

Author: hvitved

rust/ql/src/queries/telemetry/DatabaseQuality.qll

@@ -21,7 +21,10 @@ private class RelevantFile extends File {
 module CallTargetStats implements StatsSig {
   int getNumberOfOk() {
     result =
-      count(CallExprBase c | c.getFile() instanceof RelevantFile and exists(c.getStaticTarget()))
+      count(CallExprBase c |
+        c.getFile() instanceof RelevantFile and
+        c.(Resolvable).hasResolvedPath()
+      )
   }
 
   private predicate isLambdaCall(CallExpr call) {
@@ -33,7 +36,7 @@ module CallTargetStats implements StatsSig {
 
   additional predicate isNotOkCall(CallExprBase c) {
     c.getFile() instanceof RelevantFile and
-    not exists(c.getStaticTarget()) and
+    not c.(Resolvable).hasResolvedPath() and
     not isLambdaCall(c)
   }
 

rust/ql/test/extractor-tests/generated/MethodCallExpr/MethodCallExpr.expected

@@ -8,6 +8,8 @@ getAttr
 getArg
 | gen_method_call_expr.rs:5:5:5:13 | x.foo(...) | 0 | gen_method_call_expr.rs:5:11:5:12 | 42 |
 | gen_method_call_expr.rs:6:5:6:25 | x.foo(...) | 0 | gen_method_call_expr.rs:6:23:6:24 | 42 |
+getResolvedPath
+getResolvedCrateOrigin
 getGenericArgList
 | gen_method_call_expr.rs:6:5:6:25 | x.foo(...) | gen_method_call_expr.rs:6:10:6:21 | <...> |
 getIdentifier

rust/ql/test/extractor-tests/generated/Path/PathExpr.expected

@@ -5,6 +5,8 @@ instances
 | gen_path_expr.rs:7:13:7:20 | ...::foo |
 | gen_path_expr.rs:8:13:8:36 | ...::foo |
 | gen_path_pat.rs:5:11:5:11 | x |
+getResolvedPath
+getResolvedCrateOrigin
 getPath
 | gen_path.rs:6:5:6:12 | ...::bar | gen_path.rs:6:5:6:12 | ...::bar |
 | gen_path_expr.rs:5:13:5:20 | variable | gen_path_expr.rs:5:13:5:20 | variable |

rust/ql/test/extractor-tests/generated/Path/PathPat.expected

@@ -1,4 +1,6 @@
 instances
 | gen_path_pat.rs:6:9:6:16 | ...::Bar |
+getResolvedPath
+getResolvedCrateOrigin
 getPath
 | gen_path_pat.rs:6:9:6:16 | ...::Bar | gen_path_pat.rs:6:9:6:16 | ...::Bar |

rust/ql/test/extractor-tests/generated/StructExpr/StructExpr.expected

@@ -3,6 +3,8 @@ instances
 | gen_struct_expr.rs:6:18:6:38 | Foo {...} |
 | gen_struct_expr.rs:7:13:7:30 | Foo {...} |
 | gen_struct_expr.rs:8:5:8:20 | Foo {...} |
+getResolvedPath
+getResolvedCrateOrigin
 getPath
 | gen_struct_expr.rs:5:17:5:34 | Foo {...} | gen_struct_expr.rs:5:17:5:19 | Foo |
 | gen_struct_expr.rs:6:18:6:38 | Foo {...} | gen_struct_expr.rs:6:18:6:20 | Foo |

rust/ql/test/extractor-tests/generated/StructPat/StructPat.expected

@@ -1,6 +1,8 @@
 instances
 | gen_struct_pat.rs:6:9:6:26 | Foo {...} |
 | gen_struct_pat.rs:7:9:7:18 | Foo {...} |
+getResolvedPath
+getResolvedCrateOrigin
 getPath
 | gen_struct_pat.rs:6:9:6:26 | Foo {...} | gen_struct_pat.rs:6:9:6:11 | Foo |
 | gen_struct_pat.rs:7:9:7:18 | Foo {...} | gen_struct_pat.rs:7:9:7:11 | Foo |

rust/ql/test/extractor-tests/generated/TupleStructPat/TupleStructPat.expected

@@ -2,6 +2,8 @@ instances
 | gen_tuple_struct_pat.rs:6:9:6:27 | Tuple(...) |
 | gen_tuple_struct_pat.rs:7:9:7:20 | Tuple(...) |
 | gen_tuple_struct_pat.rs:8:9:8:17 | Tuple(...) |
+getResolvedPath
+getResolvedCrateOrigin
 getPath
 | gen_tuple_struct_pat.rs:6:9:6:27 | Tuple(...) | gen_tuple_struct_pat.rs:6:9:6:13 | Tuple |
 | gen_tuple_struct_pat.rs:7:9:7:20 | Tuple(...) | gen_tuple_struct_pat.rs:7:9:7:13 | Tuple |