Apply suggestions from code review

MathiasVP · geoffw0 · web-flow · commit cfbb9e3339f8 · 2022-10-06T17:04:56.000+01:00
Co-authored-by: Geoffrey White &lt;40627776+geoffw0@users.noreply.github.com&gt;
diff --git a/swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll b/swift/ql/lib/codeql/swift/dataflow/internal/DataFlowPrivate.qll
@@ -148,6 +148,7 @@ private module Cached {
     // flow through `!`
     nodeFrom.asExpr() = nodeTo.asExpr().(ForceValueExpr).getSubExpr()
     or
+    // flow through a flow summary (extension of `SummaryModelCsv`)
     FlowSummaryImpl::Private::Steps::summaryLocalStep(nodeFrom, nodeTo, true)
   }
 
diff --git a/swift/ql/lib/codeql/swift/dataflow/internal/TaintTrackingPrivate.qll b/swift/ql/lib/codeql/swift/dataflow/internal/TaintTrackingPrivate.qll
@@ -49,6 +49,7 @@ private module Cached {
       ae.getType().getName() = "String"
     )
     or
+    // flow through a flow summary (extension of `SummaryModelCsv`)
     FlowSummaryImpl::Private::Steps::summaryLocalStep(nodeFrom, nodeTo, false)
   }
 
diff --git a/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Url.qll b/swift/ql/lib/codeql/swift/frameworks/StandardLibrary/Url.qll
@@ -14,6 +14,9 @@ private class UrlRemoteFlowSource extends SourceModelCsv {
   }
 }
 
+/**
+ * A model for `URL` members that permit taint flow.
+ */
 private class UrlSummaries extends SummaryModelCsv {
   override predicate row(string row) {
     row =

Original file line number	Diff line number	Diff line change
`@@ -148,6 +148,7 @@ private module Cached {`
`148`	`148`	// flow through `!`
`149`	`149`	`nodeFrom.asExpr() = nodeTo.asExpr().(ForceValueExpr).getSubExpr()`
`150`	`150`	`or`
	`151`	+ // flow through a flow summary (extension of `SummaryModelCsv`)
`151`	`152`	`FlowSummaryImpl::Private::Steps::summaryLocalStep(nodeFrom, nodeTo, true)`
`152`	`153`	`}`
`153`	`154`
Original file line number	Diff line number	Diff line change
`@@ -49,6 +49,7 @@ private module Cached {`
`49`	`49`	`ae.getType().getName() = "String"`
`50`	`50`	`)`
`51`	`51`	`or`
	`52`	+ // flow through a flow summary (extension of `SummaryModelCsv`)
`52`	`53`	`FlowSummaryImpl::Private::Steps::summaryLocalStep(nodeFrom, nodeTo, false)`
`53`	`54`	`}`
`54`	`55`
Original file line number	Diff line number	Diff line change
`@@ -14,6 +14,9 @@ private class UrlRemoteFlowSource extends SourceModelCsv {`
`14`	`14`	`}`
`15`	`15`	`}`
`16`	`16`
	`17`	`+/**`
	`18`	+ * A model for `URL` members that permit taint flow.
	`19`	`+ */`
`17`	`20`	`private class UrlSummaries extends SummaryModelCsv {`
`18`	`21`	`override predicate row(string row) {`
`19`	`22`	`row =`