Skip to content

Commit cf05414

Browse files
committed
Address review comments (iv)
1 parent 2cc8b7f commit cf05414

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

rust/ql/lib/codeql/rust/internal/TypeInference.qll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1381,7 +1381,7 @@ private module MethodResolution {
13811381
exists(mc.getACandidateReceiverTypeAt(derefChain, borrow, _))
13821382
}
13831383

1384-
/** A method call tagged with a candidate receiver type. */
1384+
/** A method call with a dereference chain and a potential borrow. */
13851385
private class MethodCallCand extends MkMethodCallCand {
13861386
MethodCall mc_;
13871387
string derefChain;

rust/ql/lib/codeql/rust/internal/typeinference/FunctionType.qll

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ private newtype TAssocFunctionType =
7777
exists(pos.getTypeMention(f))
7878
} or
7979
MkInheritedAssocFunctionType(
80-
Function f, FunctionPosition pos, TypeMention parentMention, ImplOrTraitItemNode parent,
80+
Function f, FunctionPosition pos, TypeMention parentMention, TraitItemNode parent,
8181
ImplOrTraitItemNode i
8282
) {
8383
exists(AssocFunctionType inherited |
@@ -132,7 +132,7 @@ class AssocFunctionType extends TAssocFunctionType {
132132
}
133133

134134
private predicate isInheritedFunctionType(
135-
Function f, FunctionPosition pos, TypeMention parentMention, ImplOrTraitItemNode parent,
135+
Function f, FunctionPosition pos, TypeMention parentMention, TraitItemNode parent,
136136
ImplOrTraitItemNode i
137137
) {
138138
this = MkInheritedAssocFunctionType(f, pos, parentMention, parent, i)
@@ -157,7 +157,7 @@ class AssocFunctionType extends TAssocFunctionType {
157157
)
158158
or
159159
exists(
160-
Function f, FunctionPosition pos, TypeMention parentMention, ImplOrTraitItemNode parent,
160+
Function f, FunctionPosition pos, TypeMention parentMention, TraitItemNode parent,
161161
AssocFunctionType parentType, ImplOrTraitItemNode i
162162
|
163163
this.isInheritedFunctionType(f, pos, parentMention, parent, i) and

0 commit comments

Comments
 (0)