@@ -31,7 +31,7 @@ Function getASuperCallTargetFromCall(
3131 )
3232}
3333
34- /** Gets the method called by `meth` named `name` with `call`, with `mroBase` as the type determining the MRO to search. */
34+ /** Gets the method called by `meth` named `name` with `call`, with `mroBase` as the type determining the MRO to search. */
3535Function getDirectSuperCallTargetFromCall (
3636 Class mroBase , Function meth , DataFlow:: MethodCallNode call , string name
3737) {
@@ -54,7 +54,7 @@ Function getDirectSuperCallTargetFromCall(
5454 )
5555}
5656
57- /** Gets a method that is transitively called by a call to `cls.<name>`, with `mroBase` as the type determining the MRO to search. */
57+ /** Gets a method that is transitively called by a call to `cls.<name>`, with `mroBase` as the type determining the MRO to search. */
5858Function getASuperCallTargetFromClass ( Class mroBase , Class cls , string name ) {
5959 exists ( Function target |
6060 target = findFunctionAccordingToMroKnownStartingClass ( cls , mroBase , name ) and
@@ -79,7 +79,7 @@ predicate nonTrivial(Function meth) {
7979 exists ( meth .getANormalExit ( ) ) // doesn't always raise an exception
8080}
8181
82- /** Holds if `call` is a call to `super().<name>`. No distinction is made btween 0- and 2- arg super calls. */
82+ /** Holds if `call` is a call to `super().<name>`. No distinction is made between 0- and 2- arg super calls. */
8383predicate superCall ( DataFlow:: MethodCallNode call , string name ) {
8484 exists ( DataFlow:: Node sup |
8585 call .calls ( sup , name ) and
@@ -127,8 +127,9 @@ predicate missingCallToSuperclassMethod(Class base, Function shouldCall, string
127127 not callsMethodOnUnknownClassWithSelf ( getASuperCallTargetFromClass ( base , base , name ) , name )
128128}
129129
130- /** Holds if `base` does not call a superclass method `shouldCall` named `name` when it appears it should.
131- * Results are restricted to hold only for the highest `base` class and the lowest `shouldCall` method in the heirarchy for which this applies.
130+ /**
131+ * Holds if `base` does not call a superclass method `shouldCall` named `name` when it appears it should.
132+ * Results are restricted to hold only for the highest `base` class and the lowest `shouldCall` method in the hierarchy for which this applies.
132133 */
133134predicate missingCallToSuperclassMethodRestricted ( Class base , Function shouldCall , string name ) {
134135 missingCallToSuperclassMethod ( base , shouldCall , name ) and
@@ -144,11 +145,11 @@ predicate missingCallToSuperclassMethodRestricted(Class base, Function shouldCal
144145 )
145146}
146147
147- /**
148- * If `base` contains a `super()` call, gets a method in the inheritence heirarchy of `name` in the MRO of `base`
148+ /**
149+ * If `base` contains a `super()` call, gets a method in the inheritance hierarchy of `name` in the MRO of `base`
149150 * that does not contain a `super()` call, but would call `shouldCall` if it did, which does not otherwise get called
150- * during a call to `base.<name>`.
151- * * /
151+ * during a call to `base.<name>`.
152+ */
152153Function getPossibleMissingSuper ( Class base , Function shouldCall , string name ) {
153154 missingCallToSuperclassMethod ( base , shouldCall , name ) and
154155 exists ( Function baseMethod |
0 commit comments