Crypto: ql-for-ql alert fixes.

bdrodes · bdrodes · commit c50175bc9b8c · 2025-10-21T10:32:00.000-04:00
diff --git a/java/ql/src/experimental/quantum/Examples/BadMacOrder.qll b/java/ql/src/experimental/quantum/Examples/BadMacOrder.qll
@@ -18,8 +18,8 @@ predicate isDecryptToMacFlow(ArtifactFlow::PathNode src, ArtifactFlow::PathNode
 }
 
 predicate isDecryptToMacNode(Crypto::ArtifactNode node) {
-  exists(ArtifactFlow::PathNode src, ArtifactFlow::PathNode sink |
-    isDecryptToMacFlow(src, sink) and
+  exists(ArtifactFlow::PathNode src |
+    isDecryptToMacFlow(src, _) and
     node.asElement() = src.getNode().asExpr()
   )
 }
diff --git a/java/ql/src/experimental/quantum/Examples/BadMacOrderDecryptToMac.ql b/java/ql/src/experimental/quantum/Examples/BadMacOrderDecryptToMac.ql
@@ -9,7 +9,6 @@
  */
 
 import java
-import experimental.quantum.Language
 import ArtifactFlow::PathGraph
 import BadMacOrder
 
diff --git a/java/ql/src/experimental/quantum/Examples/BadMacOrderMacOnEncryptPlaintext.ql b/java/ql/src/experimental/quantum/Examples/BadMacOrderMacOnEncryptPlaintext.ql
@@ -9,7 +9,6 @@
  */
 
 import java
-import experimental.quantum.Language
 import BadMacOrder
 import PlaintextUseAsMacAndCipherInputFlow::PathGraph
 

Original file line number	Diff line number	Diff line change
`@@ -18,8 +18,8 @@ predicate isDecryptToMacFlow(ArtifactFlow::PathNode src, ArtifactFlow::PathNode`
`18`	`18`	`}`
`19`	`19`
`20`	`20`	`predicate isDecryptToMacNode(Crypto::ArtifactNode node) {`
`21`		`- exists(ArtifactFlow::PathNode src, ArtifactFlow::PathNode sink \|`
`22`		`- isDecryptToMacFlow(src, sink) and`
	`21`	`+ exists(ArtifactFlow::PathNode src \|`
	`22`	`+ isDecryptToMacFlow(src, _) and`
`23`	`23`	`node.asElement() = src.getNode().asExpr()`
`24`	`24`	`)`
`25`	`25`	`}`