Address review findings

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/Assets.cs

@@ -189,13 +189,13 @@ private void AddFrameworkDependencies(JObject json, string jsonPath)
         /// (together with used package information) required for compilation.
         /// </summary>
         /// <returns>True if parsing succeeds, otherwise false.</returns>
-        public bool TryParse(string json, string? jsonPath = null)
+        public bool TryParse(string json, string jsonPath)
         {
             try
             {
                 var obj = JObject.Parse(json);
-                AddPackageDependencies(obj, jsonPath ?? json);
-                AddFrameworkDependencies(obj, jsonPath ?? json);
+                AddPackageDependencies(obj, jsonPath);
+                AddFrameworkDependencies(obj, jsonPath);
                 return true;
             }
             catch (Exception e)

csharp/extractor/Semmle.Extraction.Tests/Assets.cs

@@ -16,7 +16,7 @@ public void TestAssets1()
             var json = assetsJson1;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -46,7 +46,7 @@ public void TestAssetsFailure()
             var json = "garbage data";
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.False(success);
@@ -61,7 +61,7 @@ public void TestAssetsNet70()
             var json = assetsNet70;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -91,7 +91,7 @@ public void TestAssetsNet48()
             var json = assetsNet48;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -117,7 +117,7 @@ public void TestAssetsNetstandard21()
             var json = assetsNetstandard21;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -144,7 +144,7 @@ public void TestAssetsNetStandard16()
             var json = assetsNetstandard16;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -175,7 +175,7 @@ public void TestAssetsNetcoreapp20()
             var json = assetsNetcoreapp20;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);
@@ -202,7 +202,7 @@ public void TestAssetsNetcoreapp31()
             var json = assetsNetcoreapp31;
 
             // Execute
-            var success = assets.TryParse(json);
+            var success = assets.TryParse(json, "");
 
             // Verify
             Assert.True(success);