JS: Avoid duplication with constructor body

Author: asgerf

javascript/ql/lib/semmle/javascript/dataflow/Nodes.qll

@@ -872,6 +872,7 @@ class ClassNode extends DataFlow::ValueNode, DataFlow::SourceNode {
     or
     // Function-style class case
     astNode instanceof Function and
+    not astNode = any(ClassDefinition cls).getConstructor().getBody() and
     function.getFunction() = astNode and
     (
       exists(getAFunctionValueWithPrototype(function))

javascript/ql/test/library-tests/ClassNode/tests.expected

@@ -15,7 +15,6 @@ getAReceiverNode
 | tst.js:3:1:10:1 | class A ... () {}\\n} | tst.js:4:17:4:16 | this |
 | tst.js:3:1:10:1 | class A ... () {}\\n} | tst.js:7:6:7:5 | this |
 | tst.js:3:1:10:1 | class A ... () {}\\n} | tst.js:9:10:9:9 | this |
-| tst.js:3:9:3:8 | () {} | tst.js:3:9:3:8 | this |
 | tst.js:13:1:13:21 | class A ... ds A {} | tst.js:13:20:13:19 | this |
 | tst.js:15:1:15:15 | function B() {} | tst.js:15:1:15:0 | this |
 | tst.js:15:1:15:15 | function B() {} | tst.js:17:19:17:18 | this |

javascript/ql/test/library-tests/Classes/tests.expected

@@ -194,7 +194,6 @@ test_ConstructorDefinitions
 | tst.js:11:9:11:8 | constructor() {} |
 test_ClassNodeConstructor
 | dataflow.js:4:2:13:2 | class F ... \\n\\t\\t}\\n\\t} | dataflow.js:4:12:4:11 | () {} |
-| dataflow.js:4:12:4:11 | () {} | dataflow.js:4:12:4:11 | () {} |
 | fields.js:1:1:4:1 | class C ...  = 42\\n} | fields.js:1:9:1:8 | () {} |
 | points.js:1:1:18:1 | class P ... ;\\n  }\\n} | points.js:2:14:5:3 | (x, y)  ...  y;\\n  } |
 | points.js:20:1:33:1 | class C ... ;\\n  }\\n} | points.js:21:14:24:3 | (x, y,  ...  c;\\n  } |