Merge pull request #15808 from tamasvajk/buildless/package-source-telemetry

C#: Add package source error count to DB

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/DependencyManager.cs

@@ -814,6 +814,7 @@ private void AnalyseProject(FileInfo project)
         private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out IEnumerable<string> assets)
         {
             var successCount = 0;
+            var nugetSourceFailures = 0;
             var assetFiles = new List<string>();
             var projects = solutions.SelectMany(solution =>
                 {
@@ -823,11 +824,16 @@ private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out
                     {
                         successCount++;
                     }
+                    if (res.HasNugetPackageSourceError)
+                    {
+                        nugetSourceFailures++;
+                    }
                     assetFiles.AddRange(res.AssetsFilePaths);
                     return res.RestoredProjects;
                 }).ToList();
             assets = assetFiles;
             CompilationInfos.Add(("Successfully restored solution files", successCount.ToString()));
+            CompilationInfos.Add(("Failed solution restore with package source error", nugetSourceFailures.ToString()));
             CompilationInfos.Add(("Restored projects through solution files", projects.Count.ToString()));
             return projects;
         }
@@ -841,6 +847,7 @@ private IEnumerable<string> RestoreSolutions(IEnumerable<string> solutions, out
         private void RestoreProjects(IEnumerable<string> projects, out IEnumerable<string> assets)
         {
             var successCount = 0;
+            var nugetSourceFailures = 0;
             var assetFiles = new List<string>();
             var sync = new object();
             Parallel.ForEach(projects, new ParallelOptions { MaxDegreeOfParallelism = threads }, project =>
@@ -853,11 +860,16 @@ private void RestoreProjects(IEnumerable<string> projects, out IEnumerable<strin
                     {
                         successCount++;
                     }
+                    if (res.HasNugetPackageSourceError)
+                    {
+                        nugetSourceFailures++;
+                    }
                     assetFiles.AddRange(res.AssetsFilePaths);
                 }
             });
             assets = assetFiles;
             CompilationInfos.Add(("Successfully restored project files", successCount.ToString()));
+            CompilationInfos.Add(("Failed project restore with package source error", nugetSourceFailures.ToString()));
         }
 
         [GeneratedRegex(@"^(.+)\.(\d+\.\d+\.\d+(-(.+))?)$", RegexOptions.IgnoreCase | RegexOptions.Compiled | RegexOptions.Singleline)]

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error/CompilationInfo.expected

@@ -0,0 +1,17 @@
+| Failed project restore with package source error | 1.0 |
+| Failed solution restore with package source error | 0.0 |
+| Fallback nuget restore | 1.0 |
+| Project files on filesystem | 1.0 |
+| Resolved assembly conflicts | 7.0 |
+| Restored .NET framework variants | 0.0 |
+| Restored projects through solution files | 0.0 |
+| Solution files on filesystem | 1.0 |
+| Source files generated | 0.0 |
+| Source files on filesystem | 1.0 |
+| Successfully ran fallback nuget restore | 1.0 |
+| Successfully restored project files | 0.0 |
+| Successfully restored solution files | 1.0 |
+| Unresolved references | 0.0 |
+| UseWPF set | 0.0 |
+| UseWindowsForms set | 0.0 |
+| WebView extraction enabled | 1.0 |

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error/CompilationInfo.ql

@@ -0,0 +1,14 @@
+import csharp
+import semmle.code.csharp.commons.Diagnostics
+
+query predicate compilationInfo(string key, float value) {
+  key != "Resolved references" and
+  exists(Compilation c, string infoKey, string infoValue | infoValue = c.getInfo(infoKey) |
+    key = infoKey and
+    value = infoValue.toFloat()
+    or
+    not exists(infoValue.toFloat()) and
+    key = infoKey + ": " + infoValue and
+    value = 1
+  )
+}