Merge pull request #6899 from thepurpleowl/patch-1

RasmusWL · web-flow · commit b0af80546066 · 2021-10-19T11:24:01.000+02:00
Python SignatureOverriddenMethod: Rmv duplicate condition
diff --git a/python/ql/src/Functions/SignatureOverriddenMethod.ql b/python/ql/src/Functions/SignatureOverriddenMethod.ql
@@ -24,7 +24,6 @@ where
   not derived.getScope().isSpecialMethod() and
   derived.getName() != "__init__" and
   derived.isNormalMethod() and
-  not derived.getScope().isSpecialMethod() and
   // call to overrides distributed for efficiency
   (
     derived.overrides(base) and derived.minParameters() > base.maxParameters()

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,6 @@ where`
`24`	`24`	`not derived.getScope().isSpecialMethod() and`
`25`	`25`	`derived.getName() != "__init__" and`
`26`	`26`	`derived.isNormalMethod() and`
`27`		`- not derived.getScope().isSpecialMethod() and`
`28`	`27`	`// call to overrides distributed for efficiency`
`29`	`28`	`(`
`30`	`29`	`derived.overrides(base) and derived.minParameters() > base.maxParameters()`