C++/CleartextFileWrite

d10c · d10c · commit b0180409f41f · 2025-10-28T09:41:49.000+01:00
diff --git a/cpp/ql/src/Security/CWE/CWE-311/CleartextFileWrite.ql b/cpp/ql/src/Security/CWE/CWE-311/CleartextFileWrite.ql
@@ -35,11 +35,13 @@ module FromSensitiveConfig implements DataFlow::ConfigSig {
   predicate observeDiffInformedIncrementalMode() { any() }
 
   Location getASelectedSourceLocation(DataFlow::Node sourceNode) {
-    exists(SensitiveExpr source | result = source.getLocation() | isSourceImpl(sourceNode, source))
+    exists(SensitiveExpr source | result = [source.getLocation(), sourceNode.getLocation()] |
+      isSourceImpl(sourceNode, source)
+    )
   }
 
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    exists(FileWrite w | result = w.getLocation() | isSinkImpl(sink, w, _))
+    exists(FileWrite w | result = [w.getLocation(), sink.getLocation()] | isSinkImpl(sink, w, _))
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -35,11 +35,13 @@ module FromSensitiveConfig implements DataFlow::ConfigSig {`
`35`	`35`	`predicate observeDiffInformedIncrementalMode() { any() }`
`36`	`36`
`37`	`37`	`Location getASelectedSourceLocation(DataFlow::Node sourceNode) {`
`38`		`- exists(SensitiveExpr source \| result = source.getLocation() \| isSourceImpl(sourceNode, source))`
	`38`	`+ exists(SensitiveExpr source \| result = [source.getLocation(), sourceNode.getLocation()] \|`
	`39`	`+ isSourceImpl(sourceNode, source)`
	`40`	`+ )`
`39`	`41`	`}`
`40`	`42`
`41`	`43`	`Location getASelectedSinkLocation(DataFlow::Node sink) {`
`42`		`- exists(FileWrite w \| result = w.getLocation() \| isSinkImpl(sink, w, _))`
	`44`	`+ exists(FileWrite w \| result = [w.getLocation(), sink.getLocation()] \| isSinkImpl(sink, w, _))`
`43`	`45`	`}`
`44`	`46`	`}`
`45`	`47`