Skip to content

Commit a9dde41

Browse files
Fix up test
1 parent 3e3503a commit a9dde41

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

java/ql/lib/semmle/code/java/security/AndroidSensitiveCommunicationQuery.qll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,8 +150,8 @@ private predicate isCleanIntent(Expr intent) {
150150
/**
151151
* Taint configuration tracking flow from variables containing sensitive information to broadcast intents.
152152
*/
153-
class SensitiveBroadcastConfig extends TaintTracking::Configuration {
154-
SensitiveBroadcastConfig() { this = "Sensitive Broadcast Configuration" }
153+
class SensitiveCommunicationConfig extends TaintTracking::Configuration {
154+
SensitiveCommunicationConfig() { this = "Sensitive Communication Configuration" }
155155

156156
override predicate isSource(DataFlow::Node source) {
157157
source.asExpr() instanceof SensitiveInfoExpr

java/ql/src/Security/CWE/CWE-927/SensitiveCommunication.ql

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ import java
1414
import semmle.code.java.security.AndroidSensitiveCommunicationQuery
1515
import DataFlow::PathGraph
1616

17-
from SensitiveBroadcastConfig cfg, DataFlow::PathNode source, DataFlow::PathNode sink
17+
from SensitiveCommunicationConfig cfg, DataFlow::PathNode source, DataFlow::PathNode sink
1818
where cfg.hasFlowPath(source, sink)
19-
select sink.getNode(), source, sink, "Sending $@ to broadcast.", source.getNode(),
20-
"sensitive information"
19+
select sink.getNode(), source, sink, "This call may leak sensitive infomration from $@.",
20+
source.getNode(), "here"
Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
11
import java
2-
import semmle.code.java.security.AndroidSensitiveBroadcastQuery
2+
import semmle.code.java.security.AndroidSensitiveCommunicationQuery
33
import TestUtilities.InlineExpectationsTest
44
import TestUtilities.InlineFlowTest
55

66
class HasFlowTest extends InlineFlowTest {
7-
override DataFlow::Configuration getTaintFlowConfig() { result = any(SensitiveBroadcastConfig c) }
7+
override DataFlow::Configuration getTaintFlowConfig() {
8+
result = any(SensitiveCommunicationConfig c)
9+
}
810

911
override DataFlow::Configuration getValueFlowConfig() { none() }
1012
}

0 commit comments

Comments
 (0)