C++/OverflowDestination

d10c · d10c · commit a4ac0392a6bc · 2025-10-28T09:41:32.000+01:00
diff --git a/cpp/ql/src/Critical/OverflowDestination.ql b/cpp/ql/src/Critical/OverflowDestination.ql
@@ -85,10 +85,8 @@ module OverflowDestinationConfig implements DataFlow::ConfigSig {
 
   predicate observeDiffInformedIncrementalMode() { any() }
 
-  Location getASelectedSourceLocation(DataFlow::Node source) { none() }
-
   Location getASelectedSinkLocation(DataFlow::Node sink) {
-    exists(FunctionCall fc | result = fc.getLocation() |
+    exists(FunctionCall fc | result = [fc.getLocation(), sink.getLocation()] |
       sourceSized(fc, sink.asIndirectConvertedExpr())
     )
   }

Original file line number	Diff line number	Diff line change
`@@ -85,10 +85,8 @@ module OverflowDestinationConfig implements DataFlow::ConfigSig {`
`85`	`85`
`86`	`86`	`predicate observeDiffInformedIncrementalMode() { any() }`
`87`	`87`
`88`		`- Location getASelectedSourceLocation(DataFlow::Node source) { none() }`
`89`		`-`
`90`	`88`	`Location getASelectedSinkLocation(DataFlow::Node sink) {`
`91`		`- exists(FunctionCall fc \| result = fc.getLocation() \|`
	`89`	`+ exists(FunctionCall fc \| result = [fc.getLocation(), sink.getLocation()] \|`
`92`	`90`	`sourceSized(fc, sink.asIndirectConvertedExpr())`
`93`	`91`	`)`
`94`	`92`	`}`