File tree Expand file tree Collapse file tree 2 files changed +9
-9
lines changed
rust/ql/src/queries/security/CWE-117 Expand file tree Collapse file tree 2 files changed +9
-9
lines changed Original file line number Diff line number Diff line change @@ -3,11 +3,11 @@ use log::info;
33
44fn main ( ) {
55 env_logger:: init ( ) ;
6-
6+
77 // Get username from command line arguments
88 let args: Vec < String > = env:: args ( ) . collect ( ) ;
9- let username = args. get ( 1 ) . unwrap_or ( & String :: from ( "Guest" ) ) ;
10-
9+ let username = args. get ( 1 ) . unwrap_or ( & String :: from ( "Guest" ) ) . clone ( ) ;
10+
1111 // BAD: log message constructed with unsanitized user input
1212 info ! ( "User login attempt: {}" , username) ;
13- }
13+ }
Original file line number Diff line number Diff line change @@ -8,12 +8,12 @@ fn sanitize_for_logging(input: &str) -> String {
88
99fn main ( ) {
1010 env_logger:: init ( ) ;
11-
11+
1212 // Get username from command line arguments
1313 let args: Vec < String > = env:: args ( ) . collect ( ) ;
14- let username = args. get ( 1 ) . unwrap_or ( & String :: from ( "Guest" ) ) ;
15-
14+ let username = args. get ( 1 ) . unwrap_or ( & String :: from ( "Guest" ) ) . clone ( ) ;
15+
1616 // GOOD: log message constructed with sanitized user input
17- let sanitized_username = sanitize_for_logging ( username) ;
17+ let sanitized_username = sanitize_for_logging ( username. as_str ( ) ) ;
1818 info ! ( "User login attempt: {}" , sanitized_username) ;
19- }
19+ }
You can’t perform that action at this time.
0 commit comments