C++: Replace 'InitializeGroup' with 'UninitializedGroup'.

Author: MathiasVP

cpp/ql/lib/semmle/code/cpp/ir/dataflow/internal/SsaInternalsCommon.qll

@@ -41,7 +41,7 @@ predicate ignoreInstruction(Instruction instr) {
     instr instanceof AliasedUseInstruction or
     instr instanceof InitializeNonLocalInstruction or
     instr instanceof ReturnIndirectionInstruction or
-    instr instanceof InitializeGroupInstruction
+    instr instanceof UninitializedGroupInstruction
   )
 }
 

cpp/ql/lib/semmle/code/cpp/ir/implementation/MemoryAccessKind.qll

@@ -102,7 +102,7 @@ class ChiPartialMemoryAccess extends MemoryAccessKind, TChiPartialMemoryAccess {
 }
 
 /**
- * The result of an `InitializeGroup` instruction, which initializes a set of
+ * The result of an `UninitializedGroup` instruction, which initializes a set of
  * allocations that are each assigned the same virtual variable.
  */
 class GroupedMemoryAccess extends MemoryAccessKind, TGroupedMemoryAccess {

cpp/ql/lib/semmle/code/cpp/ir/implementation/Opcode.qll

@@ -89,7 +89,7 @@ private newtype TOpcode =
   TSizedBufferMayWriteSideEffect() or
   TInitializeDynamicAllocation() or
   TChi() or
-  TInitializeGroup() or
+  TUninitializedGroup() or
   TInlineAsm() or
   TUnreached() or
   TNewObj()
@@ -1239,12 +1239,12 @@ module Opcode {
   }
 
   /**
-   * The `Opcode` for a `InitializeGroup`.
+   * The `Opcode` for a `UninitializedGroup`.
    *
-   * See the `InitializeGroupInstruction` documentation for more details.
+   * See the `UninitializedGroupInstruction` documentation for more details.
    */
-  class InitializeGroup extends Opcode, TInitializeGroup {
-    final override string toString() { result = "InitializeGroup" }
+  class UninitializedGroup extends Opcode, TUninitializedGroup {
+    final override string toString() { result = "UninitializedGroup" }
 
     override GroupedMemoryAccess getWriteMemoryAccess() { any() }
   }

cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/Instruction.qll

@@ -2162,19 +2162,21 @@ class ChiInstruction extends Instruction {
  *
  * Since both the address of `a` and `b` reach `p` at `*p = 5` the IR alias
  * analysis will create a region that contains both `a` and `b`. The region
- * containing both `a` and `b` are initialized by an `InitializeGroup`
+ * containing both `a` and `b` are initialized by an `UninitializedGroup`
  * instruction in the entry block of the enclosing function.
  */
-class InitializeGroupInstruction extends Instruction {
-  InitializeGroupInstruction() { this.getOpcode() instanceof Opcode::InitializeGroup }
+class UninitializedGroupInstruction extends Instruction {
+  UninitializedGroupInstruction() { this.getOpcode() instanceof Opcode::UninitializedGroup }
 
   /**
    * Gets an `IRVariable` whose memory is initialized by this instruction, if any.
    * Note: Allocations that are not represented as `IRVariable`s (such as
    * dynamic allocations) are not returned by this predicate even if this
    * instruction initializes such memory.
    */
-  final IRVariable getAnIRVariable() { result = Construction::getAnInitializeGroupVariable(this) }
+  final IRVariable getAnIRVariable() {
+    result = Construction::getAnUninitializedGroupVariable(this)
+  }
 
   final override string getImmediateString() {
     result = strictconcat(this.getAnIRVariable().toString(), ",")

cpp/ql/lib/semmle/code/cpp/ir/implementation/aliased_ssa/internal/AliasedSSA.qll

@@ -179,7 +179,7 @@ class VariableGroup extends AllocationSet::EquivalenceClass {
    * getInitializationOrder() = 2
    * ```
    * then this set will be initialized as the second (third) set in the
-   * enclosing function. In order words, the third `InitializeGroup`
+   * enclosing function. In order words, the third `UninitializedGroup`
    * instruction in the entry block of the enclosing function will initialize
    * this set of allocations.
    */