Move all classes to the Semmle.Extraction.CSharp namespace

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp/BUILD.bazel

@@ -6,7 +6,6 @@ load(
 codeql_csharp_library(
     name = "Semmle.Extraction.CSharp",
     srcs = glob([
-        "_Base/**/*.cs",
         "CodeAnalysisExtensions/**/*.cs",
         "Comments/**/*.cs",
         "Entities/**/*.cs",

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/CachedEntity`1.cs renamed to csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/CachedEntity.cs

@@ -2,14 +2,14 @@
 using System.IO;
 using Microsoft.CodeAnalysis;
 
-namespace Semmle.Extraction
+namespace Semmle.Extraction.CSharp.Entities
 {
     /// <summary>
     /// A cached entity.
     ///
     /// The <see cref="Entity.Id"/> property is used as label in caching.
     /// </summary>
-    public abstract class CachedEntity : CSharp.LabelledEntity
+    public abstract class CachedEntity : LabelledEntity
     {
         protected CachedEntity(Context context) : base(context)
         {
@@ -62,7 +62,7 @@ public override bool Equals(object? obj)
             return other?.GetType() == GetType() && Equals(other.Symbol, Symbol);
         }
 
-        public override CSharp.TrapStackBehaviour TrapStackBehaviour => CSharp.TrapStackBehaviour.NoLabel;
+        public override TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
     }
 
     /// <summary>

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/CachedEntityFactory.cs

@@ -3,7 +3,7 @@ namespace Semmle.Extraction.CSharp
     /// <summary>
     /// A factory for creating cached entities.
     /// </summary>
-    public abstract class CachedEntityFactory<TInit, TEntity> where TEntity : CachedEntity
+    public abstract class CachedEntityFactory<TInit, TEntity> where TEntity : Entities.CachedEntity
     {
         public abstract TEntity Create(Context cx, TInit init);
     }

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/CachedEntityFactoryExtensions.cs

@@ -16,7 +16,7 @@ public static class CachedEntityFactoryExtensions
         /// <param name="init">The initializer for the entity.</param>
         /// <returns>The entity.</returns>
         public static TEntity CreateEntity<TInit, TEntity>(this CachedEntityFactory<TInit, TEntity> factory, Context cx, object cacheKey, TInit init)
-            where TEntity : CachedEntity => cx.CreateEntity(factory, cacheKey, init);
+            where TEntity : Entities.CachedEntity => cx.CreateEntity(factory, cacheKey, init);
 
         /// <summary>
         /// Creates and populates a new entity from an `ISymbol`, or returns the existing one
@@ -30,6 +30,6 @@ public static TEntity CreateEntity<TInit, TEntity>(this CachedEntityFactory<TIni
         /// <returns>The entity.</returns>
         public static TEntity CreateEntityFromSymbol<TSymbol, TEntity>(this CachedEntityFactory<TSymbol, TEntity> factory, Context cx, TSymbol init)
             where TSymbol : ISymbol
-            where TEntity : CachedEntity => cx.CreateEntityFromSymbol(factory, init);
+            where TEntity : Entities.CachedEntity => cx.CreateEntityFromSymbol(factory, init);
     }
 }

csharp/extractor/Semmle.Extraction.CSharp/Entities/CachedSymbol.cs renamed to csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/CachedSymbol.cs

@@ -1,8 +1,6 @@
 using System.Collections.Generic;
 using System.IO;
 using System.Linq;
-using System.Reflection.Metadata;
-using System.Reflection.Metadata.Ecma335;
 using Microsoft.CodeAnalysis;
 using Microsoft.CodeAnalysis.CSharp.Syntax;
 

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/Entity.cs

@@ -6,9 +6,9 @@ namespace Semmle.Extraction.CSharp
 {
     public abstract class Entity : IEntity
     {
-        public virtual Semmle.Extraction.Context Context { get; }
+        public virtual Context Context { get; }
 
-        protected Entity(Semmle.Extraction.Context context)
+        protected Entity(Context context)
         {
             this.Context = context;
         }

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/FreshEntity.cs

@@ -1,11 +1,11 @@
 using System.IO;
 
-namespace Semmle.Extraction
+namespace Semmle.Extraction.CSharp.Entities
 {
     /// <summary>
     /// An entity which has a default "*" ID assigned to it.
     /// </summary>
-    public abstract class FreshEntity : CSharp.UnlabelledEntity
+    public abstract class FreshEntity : UnlabelledEntity
     {
         protected FreshEntity(Context cx) : base(cx)
         {
@@ -33,6 +33,6 @@ public string DebugContents
 
         public override Microsoft.CodeAnalysis.Location? ReportingLocation => null;
 
-        public override CSharp.TrapStackBehaviour TrapStackBehaviour => CSharp.TrapStackBehaviour.NoLabel;
+        public override TrapStackBehaviour TrapStackBehaviour => TrapStackBehaviour.NoLabel;
     }
 }

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/LabelledEntity.cs

@@ -2,7 +2,7 @@ namespace Semmle.Extraction.CSharp
 {
     public abstract class LabelledEntity : Entity
     {
-        protected LabelledEntity(Semmle.Extraction.Context cx) : base(cx)
+        protected LabelledEntity(Context cx) : base(cx)
         {
         }
     }

csharp/extractor/Semmle.Extraction.CSharp/Entities/Base/UnlabelledEntity.cs

@@ -2,7 +2,7 @@ namespace Semmle.Extraction.CSharp
 {
     public abstract class UnlabelledEntity : Entity
     {
-        protected UnlabelledEntity(Extraction.Context cx) : base(cx)
+        protected UnlabelledEntity(Context cx) : base(cx)
         {
             cx.AddFreshLabel(this);
         }