Consider Int8 and UInt8 as OsLogNonRedactedTypes

atorralba · atorralba · commit 8e0a018673c6 · 2023-01-09T18:05:18.000+01:00
diff --git a/swift/ql/lib/codeql/swift/security/CleartextLogging.qll b/swift/ql/lib/codeql/swift/security/CleartextLogging.qll
@@ -53,7 +53,7 @@ private class OsLogPrivacyCleartextLoggingSanitizer extends CleartextLoggingSani
 /** A type that isn't redacted by default in an `OSLogMessage`. */
 private class OsLogNonRedactedType extends Type {
   OsLogNonRedactedType() {
-    this.getName() = [["", "U"] + "Int" + ["", "16", "32", "64"], "Double", "Float", "Bool"]
+    this.getName() = [["", "U"] + "Int" + ["", "8", "16", "32", "64"], "Double", "Float", "Bool"]
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ private class OsLogPrivacyCleartextLoggingSanitizer extends CleartextLoggingSani`
`53`	`53`	/** A type that isn't redacted by default in an `OSLogMessage`. */
`54`	`54`	`private class OsLogNonRedactedType extends Type {`
`55`	`55`	`OsLogNonRedactedType() {`
`56`		`- this.getName() = [["", "U"] + "Int" + ["", "16", "32", "64"], "Double", "Float", "Bool"]`
	`56`	`+ this.getName() = [["", "U"] + "Int" + ["", "8", "16", "32", "64"], "Double", "Float", "Bool"]`
`57`	`57`	`}`
`58`	`58`	`}`
`59`	`59`