Make Resx extraction opt-in

Author: tamasvajk

csharp/extractor/Semmle.Extraction.CSharp.DependencyFetching/SourceGenerators/ResxGenerator.cs

@@ -38,8 +38,7 @@ public ResxGenerator(
         protected override bool IsEnabled()
         {
             var resourceExtractionOption = Environment.GetEnvironmentVariable(EnvironmentVariableNames.ResourceGeneration);
-            if (resourceExtractionOption == null ||
-                bool.TryParse(resourceExtractionOption, out var shouldExtractResources) &&
+            if (bool.TryParse(resourceExtractionOption, out var shouldExtractResources) &&
                 shouldExtractResources)
             {
                 compilationInfoContainer.CompilationInfos.Add(("Resource extraction enabled", "1"));

csharp/ql/integration-tests/all-platforms/standalone_resx/CompilationInfo.expected

@@ -0,0 +1,16 @@
+| Failed project restore with package source error | 0.0 |
+| Failed solution restore with package source error | 0.0 |
+| Project files on filesystem | 1.0 |
+| Resolved assembly conflicts | 0.0 |
+| Resource extraction enabled | 1.0 |
+| Restored .NET framework variants | 1.0 |
+| Restored projects through solution files | 0.0 |
+| Solution files on filesystem | 0.0 |
+| Source files generated | 2.0 |
+| Source files on filesystem | 1.0 |
+| Successfully restored project files | 1.0 |
+| Successfully restored solution files | 0.0 |
+| Unresolved references | 0.0 |
+| UseWPF set | 0.0 |
+| UseWindowsForms set | 0.0 |
+| WebView extraction enabled | 1.0 |

csharp/ql/integration-tests/all-platforms/standalone_resx/CompilationInfo.ql

@@ -0,0 +1,15 @@
+import csharp
+import semmle.code.csharp.commons.Diagnostics
+
+query predicate compilationInfo(string key, float value) {
+  key != "Resolved references" and
+  not key.matches("Compiler diagnostic count for%") and
+  exists(Compilation c, string infoKey, string infoValue | infoValue = c.getInfo(infoKey) |
+    key = infoKey and
+    value = infoValue.toFloat()
+    or
+    not exists(infoValue.toFloat()) and
+    key = infoKey + ": " + infoValue and
+    value = 1
+  )
+}

csharp/ql/integration-tests/all-platforms/standalone_resx/test.py

@@ -1,4 +1,6 @@
 import os
 from create_database_utils import *
 
+os.environ["CODEQL_EXTRACTOR_CSHARP_BUILDLESS_EXTRACT_RESOURCES"] = "true"
+
 run_codeql_database_create(lang="csharp", extra_args=["--build-mode=none"])

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error/CompilationInfo.expected

@@ -3,7 +3,7 @@
 | Fallback nuget restore | 1.0 |
 | Project files on filesystem | 1.0 |
 | Resolved assembly conflicts | 7.0 |
-| Resource extraction enabled | 1.0 |
+| Resource extraction enabled | 0.0 |
 | Restored .NET framework variants | 0.0 |
 | Restored projects through solution files | 0.0 |
 | Solution files on filesystem | 1.0 |

csharp/ql/integration-tests/posix-only/standalone_dependencies_nuget_config_error_timeout/CompilationInfo.expected

@@ -3,7 +3,7 @@
 | Inherited Nuget feed count | 1.0 |
 | Project files on filesystem | 1.0 |
 | Resolved assembly conflicts | 7.0 |
-| Resource extraction enabled | 1.0 |
+| Resource extraction enabled | 0.0 |
 | Restored .NET framework variants | 0.0 |
 | Solution files on filesystem | 1.0 |
 | Source files generated | 0.0 |