Revert change to hasEmbeddedField

owen-mc · owen-mc · commit 87992fac889d · 2024-10-17T11:50:17.000+01:00
diff --git a/go/ql/lib/semmle/go/Types.qll b/go/ql/lib/semmle/go/Types.qll
@@ -485,7 +485,8 @@ class StructType extends @structtype, CompositeType {
    */
   private predicate hasEmbeddedField(Type tp, int depth) {
     exists(Field f | this.hasFieldCand(_, f, depth, true) |
-      tp = lookThroughPointerType(f.getType())
+      tp = f.getType() or
+      tp = f.getType().(PointerType).getBaseType()
     )
   }
 

Original file line number	Diff line number	Diff line change
`@@ -485,7 +485,8 @@ class StructType extends @structtype, CompositeType {`
`485`	`485`	`*/`
`486`	`486`	`private predicate hasEmbeddedField(Type tp, int depth) {`
`487`	`487`	`exists(Field f \| this.hasFieldCand(_, f, depth, true) \|`
`488`		`- tp = lookThroughPointerType(f.getType())`
	`488`	`+ tp = f.getType() or`
	`489`	`+ tp = f.getType().(PointerType).getBaseType()`
`489`	`490`	`)`
`490`	`491`	`}`
`491`	`492`