Go: Use standard semver format in outputEnvironmentJson

Author: mbg

go/extractor/autobuilder/build-environment.go

@@ -252,7 +252,7 @@ func outputEnvironmentJson(version util.SemVer) {
 	if version == nil {
 		content = `{ "go": {} }`
 	} else {
-		content = `{ "go": { "version": "` + version.String() + `" } }`
+		content = `{ "go": { "version": "` + version.StandardSemVer() + `" } }`
 	}
 	_, err := fmt.Fprint(os.Stdout, content)
 

go/extractor/util/semver.go

@@ -28,6 +28,8 @@ type SemVer interface {
 	IsAtMost(other SemVer) bool
 	// Returns the `major.minor` version prefix of the semantic version. For example, "v1.2.3" becomes "v1.2".
 	MajorMinor() SemVer
+	// Renders the semantic version as a standard version string, i.e. without a leading "v".
+	StandardSemVer() string
 }
 
 // The internal representation used for values known to be valid semantic versions.
@@ -122,3 +124,7 @@ func (ver semVer) IsAtMost(other SemVer) bool {
 func (ver semVer) MajorMinor() SemVer {
 	return semVer(semver.MajorMinor(string(ver)))
 }
+
+func (ver semVer) StandardSemVer() string {
+	return string(ver)[1:]
+}

go/extractor/util/semver_test.go

@@ -52,6 +52,14 @@ func TestNewSemVer(t *testing.T) {
 						result,
 					)
 				}
+				if result.StandardSemVer() != expected[1:] {
+					t.Errorf(
+						"Expected NewSemVer(\"%s\").StandardSemVer() to return \"%s\", but got \"%s\".",
+						input,
+						expected[1:],
+						result.StandardSemVer(),
+					)
+				}
 			}
 		}
 	}