Minor refactor - removed unused argument

owen-mc · owen-mc · commit 7f007e10c461 · 2025-05-01T15:40:09.000+01:00
diff --git a/go/ql/src/Security/CWE-079/HTMLTemplateEscapingPassthrough.ql b/go/ql/src/Security/CWE-079/HTMLTemplateEscapingPassthrough.ql
@@ -26,8 +26,8 @@ class UnescapedType extends Type {
 /**
  * Holds if the sink is a data value argument of a template execution call.
  */
-predicate isSinkToTemplateExec(DataFlow::Node sink, DataFlow::CallNode call) {
-  exists(Method fn, string methodName |
+predicate isSinkToTemplateExec(DataFlow::Node sink) {
+  exists(Method fn, string methodName, DataFlow::CallNode call |
     fn.hasQualifiedName("html/template", "Template", methodName) and
     call = fn.getACall()
   |
@@ -69,7 +69,7 @@ module UntrustedToTemplateExecWithConversionConfig implements DataFlow::StateCon
   }
 
   predicate isSink(DataFlow::Node sink, FlowState state) {
-    state.isAfterConversion(_) and isSinkToTemplateExec(sink, _)
+    state.isAfterConversion(_) and isSinkToTemplateExec(sink)
   }
 
   predicate isBarrier(DataFlow::Node node) {

Original file line number	Diff line number	Diff line change
`@@ -26,8 +26,8 @@ class UnescapedType extends Type {`
`26`	`26`	`/**`
`27`	`27`	`* Holds if the sink is a data value argument of a template execution call.`
`28`	`28`	`*/`
`29`		`-predicate isSinkToTemplateExec(DataFlow::Node sink, DataFlow::CallNode call) {`
`30`		`- exists(Method fn, string methodName \|`
	`29`	`+predicate isSinkToTemplateExec(DataFlow::Node sink) {`
	`30`	`+ exists(Method fn, string methodName, DataFlow::CallNode call \|`
`31`	`31`	`fn.hasQualifiedName("html/template", "Template", methodName) and`
`32`	`32`	`call = fn.getACall()`
`33`	`33`	`\|`
`@@ -69,7 +69,7 @@ module UntrustedToTemplateExecWithConversionConfig implements DataFlow::StateCon`
`69`	`69`	`}`
`70`	`70`
`71`	`71`	`predicate isSink(DataFlow::Node sink, FlowState state) {`
`72`		`- state.isAfterConversion(_) and isSinkToTemplateExec(sink, _)`
	`72`	`+ state.isAfterConversion(_) and isSinkToTemplateExec(sink)`
`73`	`73`	`}`
`74`	`74`
`75`	`75`	`predicate isBarrier(DataFlow::Node node) {`