Skip to content

Commit 7efd4d2

Browse files
committed
Rust: Accept result regression.
Presumably because of a change in context, e.g. the module wrapping this test now, or the different inputs. Either way we *should* be able to get the result, and what we *actually* get in our analysis doesn't change here either. We've just slightly changed the test and exposed a gap.
1 parent 8a7e206 commit 7efd4d2

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

rust/ql/test/library-tests/dataflow/sources/net/InlineFlow.expected

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -530,8 +530,6 @@ nodes
530530
| test.rs:501:19:501:24 | buffer | semmle.label | buffer |
531531
subpaths
532532
testFailures
533-
| test.rs:400:44:400:64 | //... | Missing result: hasTaintFlow=url |
534-
| test.rs:405:44:405:64 | //... | Missing result: hasTaintFlow=url |
535533
#select
536534
| test.rs:12:10:12:23 | remote_string1 | test.rs:11:26:11:47 | ...::get | test.rs:12:10:12:23 | remote_string1 | $@ | test.rs:11:26:11:47 | ...::get | ...::get |
537535
| test.rs:15:10:15:23 | remote_string2 | test.rs:14:26:14:47 | ...::get | test.rs:15:10:15:23 | remote_string2 | $@ | test.rs:14:26:14:47 | ...::get | ...::get |

rust/ql/test/library-tests/dataflow/sources/net/test.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -397,12 +397,12 @@ mod futures_rustls {
397397
// using the `AsyncReadExt::read` extension method (higher-level)
398398
let mut buffer1 = [0u8; 64];
399399
let bytes_read1 = futures::io::AsyncReadExt::read(&mut reader, &mut buffer1).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs`
400-
sink(&buffer1[..bytes_read1]); // $ hasTaintFlow=url
400+
sink(&buffer1[..bytes_read1]); // $ MISSING: hasTaintFlow=url
401401

402402
let mut buffer2 = [0u8; 64];
403403
let bytes_read2 = reader.read(&mut buffer2).await?; // we cannot resolve the `read` call, which comes from `impl<R: AsyncRead + ?Sized> AsyncReadExt for R {}` in `async_read_ext.rs`
404404

405-
sink(&buffer2[..bytes_read2]); // $ hasTaintFlow=url
405+
sink(&buffer2[..bytes_read2]); // $ MISSING: hasTaintFlow=url
406406
}
407407

408408
let mut reader2 = futures::io::BufReader::new(reader);

0 commit comments

Comments
 (0)