Swift: add ImplicitConversionExpr test

Author: redsun82

swift/extractor/visitors/ExprVisitor.cpp

@@ -618,6 +618,4 @@ codeql::UnresolvedPatternExpr ExprVisitor::translateUnresolvedPatternExpr(
   entry.sub_pattern = dispatcher_.fetchLabel(expr.getSubPattern());
   return entry;
 }
-
-static_assert(detail::HasTranslateUnresolvedPatternExpr<ExprVisitor>::value);
 }  // namespace codeql

swift/extractor/visitors/ExprVisitor.h

@@ -95,7 +95,6 @@ class ExprVisitor : public AstVisitorBase<ExprVisitor> {
   void fillAbstractClosureExpr(const swift::AbstractClosureExpr& expr,
                                codeql::AbstractClosureExpr& entry);
   TrapLabel<ArgumentTag> emitArgument(const swift::Argument& arg);
-
   void emitExplicitCastExpr(swift::ExplicitCastExpr* expr, TrapLabel<ExplicitCastExprTag> label);
   void fillIdentityExpr(const swift::IdentityExpr& expr, codeql::IdentityExpr& entry);
   void emitAnyTryExpr(swift::AnyTryExpr* expr, TrapLabel<AnyTryExprTag> label);

swift/extractor/visitors/VisitorBase.h

@@ -58,8 +58,8 @@ DEFINE_TRANSLATE_CHECKER(TypeRepr, , )
 #include "swift/AST/TypeReprNodes.def"
 }  // namespace detail
 
-// we want to override the define_visit swift visitor behaviour of chaining calls to immediate
-// superclasses by define_visit and instead provide our own TBD define_visit (using the exact type).
+// we want to override the default swift visitor behaviour of chaining calls to immediate
+// superclasses by default and instead provide our own TBD default (using the exact type).
 // Moreover, if the implementation class has translate##CLASS##KIND (that uses generated C++
 // classes), for the class of for a parent thereof, we want to use that. We detect that by using the
 // type traits HasTranslate##CLASS##KIND defined above