Skip to content

Commit 715acef

Browse files
yoffaschackmull
andauthored
Apply suggestions from code review
Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>
1 parent 3a0a899 commit 715acef

File tree

2 files changed

+1
-2
lines changed

2 files changed

+1
-2
lines changed

java/ql/lib/semmle/code/java/ConflictingAccess.qll

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -263,7 +263,6 @@ class ClassAnnotatedAsThreadSafe extends Class {
263263
not m0.isPublic() and
264264
c.getCallee().getSourceDeclaration() = m0 and
265265
c = e and
266-
// consider allowing idempotent monitors
267266
not Monitors::locallyMonitors(e, monitor) and
268267
m.getDeclaringType() = this
269268
)

java/ql/src/Likely Bugs/Concurrency/ThreadSafe.ql

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ predicate not_fully_monitored_field(
4141
cls.has_public_write_access(f)
4242
) and
4343
msg =
44-
"The field $@ is not properly synchronized in that no single monitor covers all accesses, but the class $@ is annotated as @ThreadSafe." and
44+
"This field is not properly synchronized in that no single monitor covers all accesses, but the class $@ is annotated as @ThreadSafe." and
4545
cls_name = cls.getName()
4646
}
4747

0 commit comments

Comments
 (0)