change more queries to start with "This "

Author: erik-krogh

csharp/ql/campaigns/Solorigate/src/NumberOfKnownCommandsAboveThreshold.ql

@@ -34,5 +34,5 @@ where
   total = countSolorigateCommandInEnum(e) and
   total > 10
 select e,
-  "The enum may be related to Solorigate. It matches " + total +
+  "This enum may be related to Solorigate. It matches " + total +
     " of the values used for commands in the enum."

csharp/ql/src/Security Features/CWE-078/CommandInjection.ql

@@ -19,5 +19,5 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow::PathGraph
 
 from TaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Command line depends on a $@.", source.getNode(),
+select sink.getNode(), source, sink, "This command line depends on a $@.", source.getNode(),
   "user-provided value"

csharp/ql/src/Security Features/CWE-078/StoredCommandInjection.ql

@@ -24,5 +24,5 @@ class StoredTaintTrackingConfiguration extends TaintTrackingConfiguration {
 
 from StoredTaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Command line depends on a $@.", source.getNode(),
+select sink.getNode(), source, sink, "This command line depends on a $@.", source.getNode(),
   "stored (potentially user-provided) value"

csharp/ql/src/Security Features/CWE-079/StoredXSS.ql

@@ -31,5 +31,5 @@ where
   if exists(sink.getNode().(Sink).explanation())
   then explanation = " (" + sink.getNode().(Sink).explanation() + ")"
   else explanation = ""
-select sink.getNode(), source, sink, "HTML or JavaScript write" + explanation + " depends on a $@.",
+select sink.getNode(), source, sink, "This HTML or JavaScript write" + explanation + " depends on a $@.",
   source.getNode(), "stored (potentially user-provided) value"

csharp/ql/src/Security Features/CWE-090/LDAPInjection.ql

@@ -17,5 +17,5 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow::PathGraph
 
 from TaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "LDAP query depends on a $@.", source.getNode(),
+select sink.getNode(), source, sink, "This LDAP query depends on a $@.", source.getNode(),
   "user-provided value"

csharp/ql/src/Security Features/CWE-099/ResourceInjection.ql

@@ -17,5 +17,5 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow::PathGraph
 
 from TaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Resource descriptor depends on a $@.", source.getNode(),
+select sink.getNode(), source, sink, "This resource descriptor depends on a $@.", source.getNode(),
   "user-provided value"

csharp/ql/src/Security Features/CWE-112/MissingXMLValidation.ql

@@ -18,5 +18,5 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow::PathGraph
 from TaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
 select sink.getNode(), source, sink,
-  "XML processing depends on a $@ without validation because " + sink.getNode().(Sink).getReason(),
+  "This XML processing depends on a $@ without validation because " + sink.getNode().(Sink).getReason(),
   source.getNode(), "user-provided value"

csharp/ql/src/Security Features/CWE-117/LogForging.ql

@@ -17,5 +17,5 @@ import semmle.code.csharp.dataflow.DataFlow::DataFlow::PathGraph
 
 from TaintTrackingConfiguration c, DataFlow::PathNode source, DataFlow::PathNode sink
 where c.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Log entry depends on a $@.", source.getNode(),
+select sink.getNode(), source, sink, "This log entry depends on a $@.", source.getNode(),
   "user-provided value"

csharp/ql/src/Security Features/CWE-134/UncontrolledFormatString.ql

@@ -39,5 +39,5 @@ string getSourceType(DataFlow::Node node) {
 
 from FormatStringConfiguration config, DataFlow::PathNode source, DataFlow::PathNode sink
 where config.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Format string depends on $@.", source.getNode(),
+select sink.getNode(), source, sink, "This format string depends on $@.", source.getNode(),
   ("this" + getSourceType(source.getNode()))

csharp/ql/src/Security Features/CWE-201/ExposureInTransmittedData.ql

@@ -47,5 +47,5 @@ class TaintTrackingConfiguration extends TaintTracking::Configuration {
 
 from TaintTrackingConfiguration configuration, DataFlow::PathNode source, DataFlow::PathNode sink
 where configuration.hasFlowPath(source, sink)
-select sink.getNode(), source, sink, "Data transmitted to the user depends on $@.",
+select sink.getNode(), source, sink, "This data transmitted to the user depends on $@.",
   source.getNode(), "sensitive information"