Merge pull request #6916 from geoffw0/fixnotbound

jbj · web-flow · commit 7015be7cad86 · 2021-10-19T16:46:42.000+02:00
C++: Fix unbound variables in PrivateCleartextWrite.qll.
diff --git a/cpp/ql/lib/experimental/semmle/code/cpp/security/PrivateCleartextWrite.qll b/cpp/ql/lib/experimental/semmle/code/cpp/security/PrivateCleartextWrite.qll
@@ -52,11 +52,8 @@ module PrivateCleartextWrite {
 
   class WriteSink extends Sink {
     WriteSink() {
-      exists(FileWrite f, BufferWrite b |
-        this.asExpr() = f.getASource()
-        or
-        this.asExpr() = b.getAChild()
-      )
+      this.asExpr() = any(FileWrite f).getASource() or
+      this.asExpr() = any(BufferWrite b).getAChild()
     }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -52,11 +52,8 @@ module PrivateCleartextWrite {`
`52`	`52`
`53`	`53`	`class WriteSink extends Sink {`
`54`	`54`	`WriteSink() {`
`55`		`- exists(FileWrite f, BufferWrite b \|`
`56`		`- this.asExpr() = f.getASource()`
`57`		`- or`
`58`		`- this.asExpr() = b.getAChild()`
`59`		`- )`
	`55`	`+ this.asExpr() = any(FileWrite f).getASource() or`
	`56`	`+ this.asExpr() = any(BufferWrite b).getAChild()`
`60`	`57`	`}`
`61`	`58`	`}`
`62`	`59`	`}`