C#: Make sure no file is added twice to the compilation

tamasvajk · tamasvajk · commit 6c8e391a635c · 2024-06-18T13:45:09.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs b/csharp/extractor/Semmle.Extraction.CSharp/Extractor/Extractor.cs
@@ -398,7 +398,7 @@ private static ExitCode AnalyseTracing(
                     }
 
                     return ReadSyntaxTrees(
-                        paths.Select(analyser.PathCache.GetCanonicalPath),
+                        paths.Select(analyser.PathCache.GetCanonicalPath).ToHashSet(),
                         analyser,
                         compilerArguments.ParseOptions,
                         compilerArguments.Encoding,
diff --git a/csharp/ql/integration-tests/all-platforms/source_generator/Diag.expected b/csharp/ql/integration-tests/all-platforms/source_generator/Diag.expected
@@ -1 +0,0 @@
-| Generated/x.cs:2:7:2:7 | CS0101: The namespace '<global namespace>' already contains a definition for 'X' |

Original file line number	Diff line number	Diff line change
`@@ -398,7 +398,7 @@ private static ExitCode AnalyseTracing(`
`398`	`398`	`}`
`399`	`399`
`400`	`400`	`return ReadSyntaxTrees(`
`401`		`- paths.Select(analyser.PathCache.GetCanonicalPath),`
	`401`	`+ paths.Select(analyser.PathCache.GetCanonicalPath).ToHashSet(),`
`402`	`402`	`analyser,`
`403`	`403`	`compilerArguments.ParseOptions,`
`404`	`404`	`compilerArguments.Encoding,`
Original file line number	Diff line number	Diff line change
`@@ -1 +0,0 @@`
`1`		`-\| Generated/x.cs:2:7:2:7 \| CS0101: The namespace '<global namespace>' already contains a definition for 'X' \|`