Improve code quality

tamasvajk · tamasvajk · commit 6a036f4e84b8 · 2024-07-03T12:45:47.000+02:00
diff --git a/csharp/extractor/Semmle.Extraction/FilePattern.cs b/csharp/extractor/Semmle.Extraction/FilePattern.cs
@@ -80,15 +80,15 @@ bool HasCharAt(int i, Predicate<char> p) =>
                         if (i + 2 < pattern.Length)
                         {
                             // Processing .../**/...
+                            //                ^^^
                             sb.Append("(.*/|)");
                             i += 3;
                         }
                         else
                         {
-                            // Processing .../**
-                            sb.Append(".*");
-                            // There's no need to add another .* to the end outside the loop, we can return early.
-                            return sb;
+                            // Processing .../** at the end of the pattern.
+                            // There's no need to add .* because it's anyways added outside the loop.
+                            break;
                         }
                     }
                     else

Original file line number	Diff line number	Diff line change
`@@ -80,15 +80,15 @@ bool HasCharAt(int i, Predicate<char> p) =>`
`80`	`80`	`if (i + 2 < pattern.Length)`
`81`	`81`	`{`
`82`	`82`	`// Processing .../**/...`
	`83`	`+ // ^^^`
`83`	`84`	`sb.Append("(.*/\|)");`
`84`	`85`	`i += 3;`
`85`	`86`	`}`
`86`	`87`	`else`
`87`	`88`	`{`
`88`		`- // Processing .../**`
`89`		`- sb.Append(".*");`
`90`		`- // There's no need to add another .* to the end outside the loop, we can return early.`
`91`		`- return sb;`
	`89`	`+ // Processing .../** at the end of the pattern.`
	`90`	`+ // There's no need to add .* because it's anyways added outside the loop.`
	`91`	`+ break;`
`92`	`92`	`}`
`93`	`93`	`}`
`94`	`94`	`else`