Merge pull request #20380 from aschackmull/java/fix-broken-perf

aschackmull · web-flow · commit 66379deadda0 · 2025-09-08T08:59:31.000+02:00
Java: Fix broken performance.
diff --git a/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql b/java/ql/src/Violations of Best Practice/Naming Conventions/ConfusingOverloading.ql
@@ -66,8 +66,8 @@ private predicate candidateMethod(RefType t, Method m, string name, int numParam
 predicate paramTypePair(Type t1, Type t2) {
   exists(Method n, Method m, int i |
     overloadedMethodsMostSpecific(n, m) and
-    t1 = n.getParameterType(i) and
-    t2 = m.getParameterType(i)
+    t1 = n.getParameterType(pragma[only_bind_into](i)) and
+    t2 = m.getParameterType(pragma[only_bind_into](i))
   )
 }
 
@@ -93,6 +93,7 @@ predicate potentiallyConfusingTypesRefTypes(RefType t1, RefType t2) {
 }
 
 // then check hasSubtypeOrInstantiation
+pragma[nomagic]
 predicate potentiallyConfusingTypes(Type t1, Type t2) {
   potentiallyConfusingTypesSimple(t1, t2)
   or

Original file line number	Diff line number	Diff line change
`@@ -66,8 +66,8 @@ private predicate candidateMethod(RefType t, Method m, string name, int numParam`
`66`	`66`	`predicate paramTypePair(Type t1, Type t2) {`
`67`	`67`	`exists(Method n, Method m, int i \|`
`68`	`68`	`overloadedMethodsMostSpecific(n, m) and`
`69`		`- t1 = n.getParameterType(i) and`
`70`		`- t2 = m.getParameterType(i)`
	`69`	`+ t1 = n.getParameterType(pragma[only_bind_into](i)) and`
	`70`	`+ t2 = m.getParameterType(pragma[only_bind_into](i))`
`71`	`71`	`)`
`72`	`72`	`}`
`73`	`73`
`@@ -93,6 +93,7 @@ predicate potentiallyConfusingTypesRefTypes(RefType t1, RefType t2) {`
`93`	`93`	`}`
`94`	`94`
`95`	`95`	`// then check hasSubtypeOrInstantiation`
	`96`	`+pragma[nomagic]`
`96`	`97`	`predicate potentiallyConfusingTypes(Type t1, Type t2) {`
`97`	`98`	`potentiallyConfusingTypesSimple(t1, t2)`
`98`	`99`	`or`