Crypto: Simplifying expression for ql-for-ql alert.

bdrodes · bdrodes · commit 65d0ca9e53f5 · 2025-10-24T14:08:25.000-04:00
diff --git a/java/ql/src/experimental/quantum/Examples/BadMacOrder.qll b/java/ql/src/experimental/quantum/Examples/BadMacOrder.qll
@@ -109,7 +109,7 @@ module WrapperArgFlowConfig implements DataFlow::ConfigSig {
   predicate isBarrierOut(DataFlow::Node node) {
     // stop all flow out of a call return
     // TODO: this might be too strict and remove taint flow, need to reassess
-    exists(Call c | c = node.asExpr()) or
+    node.asExpr() instanceof Call or
     node = any(Crypto::FlowAwareElement element).getInputNode()
   }
 

Original file line number	Diff line number	Diff line change
`@@ -109,7 +109,7 @@ module WrapperArgFlowConfig implements DataFlow::ConfigSig {`
`109`	`109`	`predicate isBarrierOut(DataFlow::Node node) {`
`110`	`110`	`// stop all flow out of a call return`
`111`	`111`	`// TODO: this might be too strict and remove taint flow, need to reassess`
`112`		`- exists(Call c \| c = node.asExpr()) or`
	`112`	`+ node.asExpr() instanceof Call or`
`113`	`113`	`node = any(Crypto::FlowAwareElement element).getInputNode()`
`114`	`114`	`}`
`115`	`115`