Java: Address review comment

IdrissRio · IdrissRio · commit 63771110a5dd · 2025-09-30T11:46:37.000+02:00
diff --git a/java/ql/integration-tests/java/evaluation-to-constant-errortype/ConstantExpAppearsNonConstant.qlref b/java/ql/integration-tests/java/evaluation-to-constant-errortype/ConstantExpAppearsNonConstant.qlref
@@ -1 +1,2 @@
-Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
+query: Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql
diff --git a/java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql b/java/ql/src/Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql
@@ -19,7 +19,7 @@ predicate isConstantExp(Expr e) {
   // A literal is constant.
   e instanceof Literal
   or
-  exists(TypeAccess ta | ta = e | not ta.getType() instanceof ErrorType)
+  e instanceof TypeAccess and not e.(TypeAccess).getType() instanceof ErrorType
   or
   e instanceof ArrayTypeAccess
   or

Original file line number	Diff line number	Diff line change
`@@ -1 +1,2 @@`
`1`		`-Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql`
	`1`	`+query: Likely Bugs/Arithmetic/ConstantExpAppearsNonConstant.ql`
	`2`	`+postprocess: utils/test/InlineExpectationsTestQuery.ql`